Attachment 92546 Details for Bug 23530 – Bug 23530: Fix cart showing only hidden items

[patch] Bug 23530: Fix cart showing only hidden items

Bug-23530-Fix-cart-showing-only-hidden-items.patch (text/plain), 1.78 KB, created by Nick Clemens (kidclamp) on 2019-09-03 13:16:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-09-03 13:16:13 UTC

Size: 1.78 KB

patch

obsolete

>From 2868342d128d66c4a844c7bfd1fc6bcecdcd72df Mon Sep 17 00:00:00 2001
>From: Mason James <mtj@kohaaloha.com>
>Date: Tue, 3 Sep 2019 16:02:32 +1200
>Subject: [PATCH] Bug 23530: Fix cart showing only hidden items
>
>Items hidden with the OpacHiddenItems system preference
>were still displayed in the OPAC cart and the normal items
>were hidden instead. This patch corrects the display.
>
>To test:
>- prep a test bib with hidden and other items using
>  the OpacHiddenItems system preference
>- add bib to cart
>- observe that hidden items are displayed - non-hidden items are hidden
>- apply patch, reload page
>- observe that hidden items are hidden, non-hidden items are displayed
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> opac/opac-basket.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/opac/opac-basket.pl b/opac/opac-basket.pl
>index 11d9387d78..dc385431e9 100755
>--- a/opac/opac-basket.pl
>+++ b/opac/opac-basket.pl
>@@ -18,7 +18,6 @@
> use Modern::Perl;
> 
> use CGI qw ( -utf8 );
>-use List::Util qw/none/; # well just one :)
> 
> use C4::Koha;
> use C4::Biblio;
>@@ -100,12 +99,14 @@ foreach my $biblionumber ( @bibs ) {
>     # copy the visible ones into the items array.
>     my @items;
>     foreach my $item (@all_items) {
>-        if ( none { $item->{itemnumber} ne $_ } @hidden_items ) {
>+
>+            # next if item is hidden
>+            next  if  grep  { $item->{itemnumber} eq $_  } @hidden_items ;
>+
>             my $reserve_status = C4::Reserves::GetReserveStatus($item->{itemnumber});
>             if( $reserve_status eq "Waiting"){ $item->{'waiting'} = 1; }
>             if( $reserve_status eq "Reserved"){ $item->{'onhold'} = 1; }
>             push @items, $item;
>-        }
>     }
> 
>     my $hasauthors = 0;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23530: 92534 | 92535 | 92536 | 92537 | 92546