Bugzilla – Attachment 92586 Details for
Bug 23537
Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23537: Overdrive won't show complete results at all times
Bug-23537-Overdrive-wont-show-complete-results-at-.patch (text/plain), 1.85 KB, created by
Liz Rea
on 2019-09-04 16:22:51 UTC
(
hide
)
Description:
Bug 23537: Overdrive won't show complete results at all times
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2019-09-04 16:22:51 UTC
Size:
1.85 KB
patch
obsolete
>From 8a033945051e441ec2a831a88a7ab770668d991a Mon Sep 17 00:00:00 2001 >From: Liz Rea <wizzyrea@gmail.com> >Date: Wed, 4 Sep 2019 02:10:21 +0000 >Subject: [PATCH] Bug 23537: Overdrive won't show complete results at all times > >To test: > >On an overdrive enabled OPAC (tough sell, I know) > > Do a search for something you know has magazines, the collection I > was looking at had "knit" as one > > Without this patch, the results will show "(many) items found in > overdrive collection" but only show a small number of them. > > With the patch, the number of results should match the number > shown/paginated. > > A site that has this fix applied, is > https://tracy.bywatersolutions.com/cgi-bin/koha/opac-overdrive-search.pl?q=knit > > Before this patch, the number of results was 44, but there were only > 8 shown. Now we see all 44 >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt >index 982e5608bb..d8bcc2dbbb 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt >@@ -118,7 +118,7 @@ function search( offset ) { > results.push( prod.title ); > if ( prod.subtitle ) results.push( ', ', prod.subtitle ); > results.push( '</a>' ); >- results.push( '<p>' + _("by") + ' ', prod.primaryCreator.name, '</p>' ); >+ if ( prod.primaryCreator ) results.push( '<p>' + _("by") + ' ', prod.primaryCreator.name, '</p>' ); > results.push( '<span class="results_summary mediatype"><span class="label">' + _("Type:") + ' </span>', prod.mediaType, '</span>' ); > > if ( prod.starRating ) { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23537
:
92586
|
92706
|
93036