Bugzilla – Attachment 92630 Details for
Bug 23252
Pressing enter should not submit form in item editor
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23252: Add missing input_marceditor class in item editor
Bug-23252-Add-missing-inputmarceditor-class-in-ite.patch (text/plain), 2.38 KB, created by
Kyle M Hall (khall)
on 2019-09-06 10:51:04 UTC
(
hide
)
Description:
Bug 23252: Add missing input_marceditor class in item editor
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2019-09-06 10:51:04 UTC
Size:
2.38 KB
patch
obsolete
>From 8d3d44c6c22233dfbc1456b3b0b05ffc576d6f2f Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 2 Jul 2019 15:57:09 +0200 >Subject: [PATCH] Bug 23252: Add missing input_marceditor class in item editor > >In serials receive and acquisition order creation from iso2709, the item edition form shows inputs that are missing "input_marceditor" class. >They are also missing tabindex and id. > >The side effect is that those inputs dont get the "noEnterSubmit" class so form is posted if a barcode scanner is used or if enter is used on keyboard. > >Test plan : >1) >1.1) Verify you have an item subfield linked to items.itemnotes, ie 952$z >1.2) Verify system preference "AcqCreateItem" is on "placing an order" >2) >2.2) Go to cataloguing module and edit an item >2.3) Verify that $z has an id, tabindex and "input_marceditor" class. >2.4) Verify that typing enter in $z does not submit the form >3) >3.1) Go to a serial with items creation, click on receive >3.2) Change status to "Arrived" >3.3) Verify that $z has an id, tabindex and "input_marceditor" class. >3.4) Verify that typing enter in $z does not submit the form >4) >4.1) Go to an acquisition basket >4.2) Click "Add to basket" and "From a staged file" >4.3) Click "Add orders" on a staged file >4.4) Go in tab "Item information" >4.5) Verify that $z has an id, tabindex and "input_marceditor" class. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Items.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 797bda6244..0b80896400 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -2560,7 +2560,7 @@ sub PrepareItemrecordDisplay { > # oversize field (textarea) > $subfield_data{marc_value} = qq(<textarea tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength">$defaultvalue</textarea>\n"); > } else { >- $subfield_data{marc_value} = "<input type=\"text\" name=\"field_value\" value=\"$defaultvalue\" size=\"50\" maxlength=\"$maxlength\" />"; >+ $subfield_data{marc_value} = qq(<input type="text" tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$maxlength" value="$defaultvalue" />); > } > push( @loop_data, \%subfield_data ); > } >-- >2.20.1 (Apple Git-117)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23252
:
91187
|
92497
|
92630
|
92631
|
93050
|
93051