Bugzilla – Attachment 92631 Details for
Bug 23252
Pressing enter should not submit form in item editor
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23252: Adds noEnterSubmit class in ajax context
Bug-23252-Adds-noEnterSubmit-class-in-ajax-context.patch (text/plain), 1.75 KB, created by
Kyle M Hall (khall)
on 2019-09-06 10:51:15 UTC
(
hide
)
Description:
Bug 23252: Adds noEnterSubmit class in ajax context
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2019-09-06 10:51:15 UTC
Size:
1.75 KB
patch
obsolete
>From 1ba708bd42230f3cfc680788bd0e947e3e0f586f Mon Sep 17 00:00:00 2001 >From: Christophe Croullebois <christophe.croullebois@biblibre.com> >Date: Thu, 29 Aug 2019 15:23:01 +0200 >Subject: [PATCH] Bug 23252: Adds noEnterSubmit class in ajax context > >In cataloging.js $(document).ready adds noEnterSubmit class. >This does not work in ajax context, it works with $(document).ajaxSuccess. > >Test plan : >1) >1.1) Verify you have an item subfield linked to items.itemnotes, ie 952$z >1.2) Verify 952$z exists in ACQ framework >2) >2.1) Verify system preference "AcqCreateItem" is on "placing an order" >2.2) Go to an acquisition basket >2.3) Click "Add to basket" and "From a new (empty) record" >2.4) Go to "Item" block >2.5) Verify that $z has "noEnterSubmit" class >2.6) Verify that typing enter in $z does not submit the form >3) >3.1) Change system preference "AcqCreateItem" to "receiving an order" >3.2) Go to "Receive shipment" >3.3) Receive an order >3.4) Go to "Item" block >3.5) Verify that $z has "noEnterSubmit" class >3.6) Verify that typing enter in $z does not submit the form > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >index b26c45bdc2..be183af7ff 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >@@ -559,4 +559,7 @@ function CheckMandatorySubfields(p){ > > $(document).ready(function() { > $("input.input_marceditor, input.indicator").addClass('noEnterSubmit'); >+ $(document).ajaxSuccess(function() { >+ $("input.input_marceditor, input.indicator").addClass('noEnterSubmit'); >+ }); > }); >-- >2.20.1 (Apple Git-117)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23252
:
91187
|
92497
|
92630
|
92631
|
93050
|
93051