Attachment 92647 Details for Bug 22744 – Bug 22744: [alternate] Remove the 'do not notify' buttons

[patch] Bug 22744: [alternate] Remove the 'do not notify' buttons

Bug-22744-alternate-Remove-the-do-not-notify-butto.patch (text/plain), 1.87 KB, created by Kyle M Hall (khall) on 2019-09-06 13:20:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2019-09-06 13:20:20 UTC

Size: 1.87 KB

patch

obsolete

>From cd9a9babc413ef990dc595c0856a838a5d5f8d72 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 13 Jun 2019 10:56:34 +0000
>Subject: [PATCH] Bug 22744: [alternate] Remove the 'do not notify' buttons
>
>These checkboxes are simply a way to clear the prefs before editing. We are not saving
>a lot of click, and we are confusing people, this patch simply removes them
>
>To test:
>1 - Edit a patron's messaging preferences
>2 - Think too hard about the 'Do not notify' boxes
>3 - Feel confused
>4 - Apply this patch
>5 - Edit a patron's messaging preferences
>6 - Confirm it feels better
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../prog/en/includes/messaging-preference-form.inc            | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
>index e0c880f652..2f948c6236 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
>@@ -11,7 +11,6 @@
>         <th>Email</th>
>         <th>Digests only <i id="info_digests" data-toggle="tooltip" title="You can ask for a digest to reduce the number of messages. Messages will be saved and sent as a single message." data-placement="right" class="fa fa-info-circle"></i></th>
>         
>-        [% UNLESS ( messaging_form_inactive ) %]<th>Do not notify</th>[% END %]
>     </tr>
>     [% FOREACH messaging_preference IN messaging_preferences %]
>     <tr>
>@@ -190,9 +189,6 @@
>       <td>-</td>
>       [% END %] -->
> 
>-      [% UNLESS ( messaging_form_inactive ) %]
>-      <td><input type="checkbox" class="none" id="none[% messaging_preference.message_attribute_id | html %]" /></td>
>-      [% END %]
>     </tr>
>     [% END %]
>   </table>
>-- 
>2.20.1 (Apple Git-117)

Actions: View | Diff | Splinter Review

Attachments on bug 22744: 88357 | 88534 | 88535 | 90454 | 90568 | 90569 | 90570 | 90571 | 90572 | 90574 | 92642 | 92643 | 92644 | 92645 | 92646 | 92647 | 93109 | 93114 | 93115