Bugzilla – Attachment 92652 Details for
Bug 22929
Enabling the GDPR_Policy will affect libraries using the SCO module in Koha
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy
Bug-22929-Allow-SCISCO-logins-independent-of-GDPRP.patch (text/plain), 1.55 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-09-06 18:20:03 UTC
(
hide
)
Description:
Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-09-06 18:20:03 UTC
Size:
1.55 KB
patch
obsolete
>From b7bb92dcf2443cf78e65bd16a67058c823caff50 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 17 May 2019 07:36:17 +0000 >Subject: [PATCH] Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy > >This patch makes Auth skip the GDPR policy check when get_template_and_user >is called for sci/sco (self checkin, checkout). >I do not really like the change in this form but the nature of self checkin >and checkout kind of dictate it (double hack). >I wanted to add a test but since that asks for mocking CGI, checkauth, etc. >the time needed for that is just too much for this simple change. > >Test plan: >Enable GDPR_Policy and self checkin/checkout. >Verify that using patrons without consent is not blocking sci/sco. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Auth.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index a7ef5fe253..24296c5996 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -172,8 +172,9 @@ sub get_template_and_user { > } > > # If we enforce GDPR and the user did not consent, redirect >+ # Exceptions for consent page itself and SCI/SCO system > if( $in->{type} eq 'opac' && $user && >- $in->{'template_name'} !~ /opac-patron-consent/ && >+ $in->{'template_name'} !~ /^(opac-patron-consent|sc[io]\/)/ && > C4::Context->preference('GDPR_Policy') eq 'Enforced' ) > { > my $consent = Koha::Patron::Consents->search({ >-- >2.23.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22929
:
89881
|
92638
| 92652