Attachment 92662 Details for Bug 23534 – Bug 23534: Use patron-title.inc on patron entry page

[patch] Bug 23534: Use patron-title.inc on patron entry page

Bug-23534-Use-patron-titleinc-on-patron-entry-page.patch (text/plain), 2.45 KB, created by Maryse Simard on 2019-09-06 19:51:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Maryse Simard

Created: 2019-09-06 19:51:03 UTC

Size: 2.45 KB

patch

obsolete

>From 429a1cb35b691b9493a89ad05ac36d2bf2272a19 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 3 Sep 2019 18:52:35 +0000
>Subject: [PATCH] Bug 23534: Use patron-title.inc on patron entry page
>
>There are a few instances where we can simplify the patron entry
>template by using the patron-title include file instead of outputting
>patron name variables one by one. This patch does so in the page title,
>page breadcrumbs, and page heading.
>
>To test, apply the patch and edit a patron record. The page title,
>breadcrumbs, and main heading should all look correct.
>
>Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
>---
> .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 770fada..954a8e5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -12,8 +12,7 @@
>         [% ELSIF ( opduplicate ) %] Duplicate patron
>         [% ELSE %] Modify patron
>         [% END %]
>-        [% IF (firstname) %][% firstname | html %] [% END %]
>-        [% IF (surname) %][% surname | html %] [% END %]
>+        [% INCLUDE 'patron-title.inc' no_html = 1 %]
>         ([% IF categoryname %]
>             [% categoryname | html %]
>         [% ELSE %]
>@@ -39,12 +38,7 @@
>             &rsaquo;
>             [% IF (firstname || surname ) %]
>                 <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber | uri %]">
>-                    [% IF (firstname) %]
>-                        [% firstname | html %]
>-                    [% END %]
>-                    [% IF (surname) %]
>-                        [% surname | html %]
>-                    [% END %]
>+                    [% INCLUDE 'patron-title.inc' %]
>                 </a> &rsaquo;
>             [% END %]
>             <strong>
>@@ -102,8 +96,7 @@
>                                 Modify patron
>                             [% END %]
> 
>-                            [% IF (firstname) %] [% firstname | html %] [% END %]
>-                            [% IF (surname) %] [% surname | html %] [% END %]
>+                            [% INCLUDE 'patron-title.inc' %]
> 
>                             ([% IF ( categoryname ) %]
>                                 [% categoryname | html %]
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 23534: 92583 | 92662 | 99767 | 99826 | 100036