Attachment 92671 Details for Bug 23004 – Bug 23004: Unit test

[patch] Bug 23004: Unit test

Bug-23004-Unit-test.patch (text/plain), 1.62 KB, created by Tomás Cohen Arazi (tcohen) on 2019-09-09 16:59:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-09-09 16:59:36 UTC

Size: 1.62 KB

patch

obsolete

>From 51379e19a32f09ab124a9a4d5acd443192f4e695 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Thu, 8 Aug 2019 08:51:14 +0200
>Subject: [PATCH] Bug 23004: Unit test
>
>Run prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> .../Koha/SearchEngine/Elasticsearch/QueryBuilder.t     | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t b/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
>index d3656eabc9..fe69eb362d 100644
>--- a/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
>+++ b/t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
>@@ -82,7 +82,7 @@ $se->mock( 'get_elasticsearch_mappings', sub {
> });
> 
> subtest 'build_authorities_query_compat() tests' => sub {
>-    plan tests => 36;
>+    plan tests => 37;
> 
>     my $qb;
> 
>@@ -160,6 +160,14 @@ subtest 'build_authorities_query_compat() tests' => sub {
>         "descending sort parameter properly formed"
>     );
> 
>+    # Authorities type
>+    $query = $qb->build_authorities_query_compat( [ 'mainentry' ],  undef, undef, ['contains'], [$search_term], 'AUTH_TYPE', 'asc' );
>+    is_deeply(
>+        $query->{query}->{bool}->{filter},
>+        { term => { 'authtype' => 'auth_type' } },
>+        "authorities type code is used as filter"
>+    );
>+
>     # Failing case
>     throws_ok {
>         $qb->build_authorities_query_compat( [ 'tomas' ],  undef, undef, ['contains'], [$search_term], 'AUTH_TYPE', 'asc' );
>-- 
>2.23.0

Actions: View | Diff | Splinter Review

Attachments on bug 23004: 90174 | 92056 | 92632 | 92634 | 92635 | 92670 | 92671