Attachment 92683 Details for Bug 18506 – Bug 18506: (follow-up) Set redirect type to 303

[patch] Bug 18506: (follow-up) Set redirect type to 303

Bug-18506-follow-up-Set-redirect-type-to-303.patch (text/plain), 1.01 KB, created by Matthias Meusburger on 2019-09-10 09:29:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthias Meusburger

Created: 2019-09-10 09:29:47 UTC

Size: 1.01 KB

patch

obsolete

>From 07c5a51ec621cc013ae7c14d1c66979e9e022f7c Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 9 Sep 2019 12:32:46 +0100
>Subject: [PATCH] Bug 18506: (follow-up) Set redirect type to 303
>
>This should ensure query parameters are passed through the redirection.
>
>Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
>---
> C4/Auth.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index cc7f312..e541155 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -1339,7 +1339,7 @@ sub checkauth {
>         #If shibOnly is enabled just go ahead and redirect directly
>         if ( (($type eq 'opac') && C4::Context->preference('opacShibOnly')) || (($type ne 'opac') && C4::Context->preference('staffShibOnly')) ) {
>             my $redirect_url = login_shib_url( $query );
>-            print $query->redirect($redirect_url);
>+            print $query->redirect( -uri => "$redirect_url", -status => 303 );
>             safe_exit;
>         }
> 
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 18506: 62810 | 79050 | 79522 | 79524 | 79540 | 89423 | 89424 | 91011 | 91012 | 91013 | 92665 | 92680 | 92681 | 92682 | 92683 | 116250 | 116251 | 116253 | 116280 | 116281 | 116282 | 116290 | 116536 | 116537 | 116538 | 116540