Attachment 92704 Details for Bug 20691 – Bug 20691: (QA follow-up) Fix atomic update

[patch] Bug 20691: (QA follow-up) Fix atomic update

Bug-20691-QA-follow-up-Fix-atomic-update.patch (text/plain), 2.97 KB, created by Tomás Cohen Arazi (tcohen) on 2019-09-10 18:32:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-09-10 18:32:57 UTC

Size: 2.97 KB

patch

obsolete

>From 2a972f8cb368980bc1722d207564a9dc2f14e091 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 10 Sep 2019 15:01:34 -0300
>Subject: [PATCH] Bug 20691: (QA follow-up) Fix atomic update
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> .../data/mysql/atomicupdate/bug_20691.perl    | 32 +++++++++++++++++++
> .../data/mysql/atomicupdate/bug_20691.sql     | 11 -------
> 2 files changed, 32 insertions(+), 11 deletions(-)
> create mode 100644 installer/data/mysql/atomicupdate/bug_20691.perl
> delete mode 100644 installer/data/mysql/atomicupdate/bug_20691.sql
>
>diff --git a/installer/data/mysql/atomicupdate/bug_20691.perl b/installer/data/mysql/atomicupdate/bug_20691.perl
>new file mode 100644
>index 0000000000..41bc517159
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_20691.perl
>@@ -0,0 +1,32 @@
>+$DBversion = 'XXX';
>+if( CheckVersion( $DBversion ) ) {
>+
>+    unless ( column_exists( 'borrowers', 'privacy_guarantor_fines' ) ) {
>+        $dbh->do(q{
>+            ALTER TABLE borrowers
>+                ADD privacy_guarantor_fines TINYINT(1) NOT NULL DEFAULT '0' AFTER privacy;
>+        });
>+    }
>+
>+    unless ( column_exists( 'deletedborrowers', 'privacy_guarantor_fines' ) ) {
>+        $dbh->do(q{
>+            ALTER TABLE deletedborrowers
>+                ADD privacy_guarantor_fines TINYINT(1) NOT NULL DEFAULT '0' AFTER privacy;
>+        });
>+    }
>+
>+    $dbh->do(q{
>+        INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type )
>+        VALUES (
>+            'AllowStaffToSetFinesVisibilityForGuarantor',  '0', NULL,
>+            'If enabled, library staff can set a patron''s fines to be visible to linked patrons from the opac.',  'YesNo'
>+        ), (
>+            'AllowPatronToSetFinesVisibilityForGuarantor',  '0', NULL,
>+            'If enabled, the patron can set fines to be visible to  his or her guarantor',  'YesNo'
>+        )
>+    });
>+
>+    # Always end with this (adjust the bug info)
>+    SetVersion( $DBversion );
>+    print "Upgrade to $DBversion done (Bug 20691 - Add ability for guarantors to view guarantee's fines in OPAC)\n";
>+}
>diff --git a/installer/data/mysql/atomicupdate/bug_20691.sql b/installer/data/mysql/atomicupdate/bug_20691.sql
>deleted file mode 100644
>index 22eb9ed035..0000000000
>--- a/installer/data/mysql/atomicupdate/bug_20691.sql
>+++ /dev/null
>@@ -1,11 +0,0 @@
>-ALTER TABLE borrowers ADD privacy_guarantor_fines BOOLEAN NOT NULL DEFAULT '0' AFTER privacy;
>-ALTER TABLE deletedborrowers ADD privacy_guarantor_fines BOOLEAN NOT NULL DEFAULT '0' AFTER privacy;
>-
>-INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type )
>-VALUES (
>-    'AllowStaffToSetFinesVisibilityForGuarantor',  '0', NULL,
>-    'If enabled, library staff can set a patron''s fines to be visible to linked patrons from the opac.',  'YesNo'
>-), (
>-    'AllowPatronToSetFinesVisibilityForGuarantor',  '0', NULL,
>-    'If enabled, the patron can set fines to be visible to  his or her guarantor',  'YesNo'
>-)
>-- 
>2.23.0

Actions: View | Diff | Splinter Review

Attachments on bug 20691: 74968 | 74969 | 74970 | 74971 | 74972 | 74973 | 74974 | 74975 | 89951 | 89952 | 89953 | 89990 | 89991 | 89992 | 89993 | 90093 | 90094 | 90095 | 90096 | 91025 | 91026 | 91159 | 91160 | 91161 | 91162 | 92385 | 92386 | 92387 | 92388 | 92485 | 92700 | 92701 | 92702 | 92703 | 92704 | 92705 | 92897