Bugzilla – Attachment 92772 Details for
Bug 22037
Regression: guarantor no longer blocked (debarred) if child is over limit, when checking out via SIP
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22037: (QA follow-up) Correct misleading comment
Bug-22037-QA-follow-up-Correct-misleading-comment.patch (text/plain), 1.26 KB, created by
Marcel de Rooy
on 2019-09-13 07:39:38 UTC
(
hide
)
Description:
Bug 22037: (QA follow-up) Correct misleading comment
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-09-13 07:39:38 UTC
Size:
1.26 KB
patch
obsolete
>From 5a72332360d80e601473ef30b4e23226e7ae5a11 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 13 Sep 2019 07:36:25 +0000 >Subject: [PATCH] Bug 22037: (QA follow-up) Correct misleading comment >Content-Type: text/plain; charset=utf-8 > >Comment needs to be corrected, and now applies to the whole code >paragraph following it. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/SIP/ILS/Patron.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm >index 96ec74ab81..497ec98771 100644 >--- a/C4/SIP/ILS/Patron.pm >+++ b/C4/SIP/ILS/Patron.pm >@@ -66,7 +66,8 @@ sub new { > my $dexpiry = $kp->{dateexpiry}; > $dexpiry and $dexpiry =~ s/-//g; # YYYYMMDD > >- my $fines_amount = $flags->{CHARGES}->{amount}; # This "amount" is the negative balance or the one of the guarantees >+ # Get fines and add fines for guarantees (depends on preference NoIssuesChargeGuarantees) >+ my $fines_amount = $flags->{CHARGES}->{amount}; > $fines_amount = ($fines_amount and $fines_amount > 0) ? $fines_amount : 0; > my $guarantees_fines_amount = $flags->{CHARGES_GUARANTEES} ? $flags->{CHARGES_GUARANTEES}->{amount} : 0; > $fines_amount += $guarantees_fines_amount; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22037
:
83436
|
91229
|
92434
|
92770
|
92771
| 92772