Bugzilla – Attachment 92924 Details for
Bug 23625
ArticleRequestsMandatoryFields* only affects field labels, does not make inputs required
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23625: Make new 'required' attributes match the currently used syntax in other templates
Bug-23625-Make-new-required-attributes-match-the-c.patch (text/plain), 5.64 KB, created by
Kyle M Hall (khall)
on 2019-09-17 19:49:35 UTC
(
hide
)
Description:
Bug 23625: Make new 'required' attributes match the currently used syntax in other templates
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2019-09-17 19:49:35 UTC
Size:
5.64 KB
patch
obsolete
>From b61f8870898ba8393a9278647887d5e1af128006 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 17 Sep 2019 15:41:12 -0400 >Subject: [PATCH] Bug 23625: Make new 'required' attributes match the currently > used syntax in other templates > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../en/modules/opac-request-article.tt | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt >index 2da2bf95ef..b5c0de07b3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt >@@ -36,7 +36,7 @@ > <li> > [% IF mandatory_fields.search('title') %] > <label for="title" class="required">Title:</label> >- <input type="text" required name="title" id="title" size="50"/> >+ <input type="text" required="required" name="title" id="title" size="50"/> > [% ELSE %] > <label for="title">Title:</label> > <input type="text" name="title" id="title" size="50"/> >@@ -46,7 +46,7 @@ > <li> > [% IF mandatory_fields.search('author') %] > <label for="author" class="required">Author:</label> >- <input type="text" required name="author" id="author" size="50"/> >+ <input type="text" required="required" name="author" id="author" size="50"/> > [% ELSE %] > <label for="author">Author:</label> > <input type="text" name="author" id="author" size="50"/> >@@ -56,7 +56,7 @@ > <li> > [% IF mandatory_fields.search('volume') %] > <label for="volume" class="required">Volume:</label> >- <input type="text" required name="volume" id="volume" size="50"/> >+ <input type="text" required="required" name="volume" id="volume" size="50"/> > [% ELSE %] > <label for="volume">Volume:</label> > <input type="text" name="volume" id="volume" size="50"/> >@@ -66,7 +66,7 @@ > <li> > [% IF mandatory_fields.search('issue') %] > <label for="issue" class="required">Issue:</label> >- <input type="text" required name="issue" id="issue" size="50"/> >+ <input type="text" required="required" name="issue" id="issue" size="50"/> > [% ELSE %] > <label for="issue">Issue:</label> > <input type="text" name="issue" id="issue" size="50"/> >@@ -76,7 +76,7 @@ > <li> > [% IF mandatory_fields.search('date') %] > <label for="date" class="required">Date:</label> >- <input type="text" required name="date" id="date" size="50"/> >+ <input type="text" required="required" name="date" id="date" size="50"/> > [% ELSE %] > <label for="date">Date:</label> > <input type="text" name="date" id="date" size="50"/> >@@ -86,7 +86,7 @@ > <li> > [% IF mandatory_fields.search('pages') %] > <label for="pages" class="required">Pages:</label> >- <input type="text" required name="pages" id="pages" size="50"/> >+ <input type="text" required="required" name="pages" id="pages" size="50"/> > [% ELSE %] > <label for="pages">Pages:</label> > <input type="text" name="pages" id="pages" size="50"/> >@@ -96,7 +96,7 @@ > <li> > [% IF mandatory_fields.search('chapters') %] > <label for="chapters" class="required">Chapters:</label> >- <input type="text" required name="chapters" id="chapters" size="50"/> >+ <input type="text" required="required" name="chapters" id="chapters" size="50"/> > [% ELSE %] > <label for="chapters">Chapters:</label> > <input type="text" name="chapters" id="chapters" size="50"/> >@@ -110,8 +110,8 @@ > > <li> > <label for="branchcode">Pickup library:</label> >- <select name="branchcode" id="branchcode"> >- [% FOREACH b IN Branches.all %]required >+ <select name="branchcode" id="branchcode" required="required"> >+ [% FOREACH b IN Branches.all %] > [% IF b.branchcode == Branches.GetLoggedInBranchcode %] > <option value="[% b.branchcode | html %]" selected="selected">[% b.branchname | html %]</option> > [% ELSE %] >-- >2.20.1 (Apple Git-117)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23625
:
92846
|
92922
|
92923
|
92924
|
93182
|
93183