Bugzilla – Attachment 9293 Details for
Bug 8005
Lost item is not anonymized when checked in
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8005 - Lost item is not anonymized when checked in
Bug-8005---Lost-item-is-not-anonymized-when-checke.patch (text/plain), 2.26 KB, created by
Kyle M Hall
on 2012-04-25 12:36:45 UTC
(
hide
)
Description:
Bug 8005 - Lost item is not anonymized when checked in
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2012-04-25 12:36:45 UTC
Size:
2.26 KB
patch
obsolete
>From 8d218adddaee7ab4cbf9a0664f517a2fd4754354 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 25 Apr 2012 08:33:21 -0400 >Subject: [PATCH] Bug 8005 - Lost item is not anonymized when checked in > >This bug is caused by the subroutine C4::Circulation::LostItem >not passing the privacy parameter when calling >C4::Circulation::MarkIssueReturned. > >This issue is actually anonymized when the item is marked as lost, >not when the item is checked in. > >Note, even if the issue is anonymized, the fine charged for lost >items still contains a description of the lost item, which is >required for the ability to forgive fees for lost items that >are later found. >--- > C4/Circulation.pm | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index b7e08f2..d2e7edc 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1525,6 +1525,7 @@ patron who last borrowed the book. > > sub AddReturn { > my ( $barcode, $branch, $exemptfine, $dropbox ) = @_; >+ > if ($branch and not GetBranchDetail($branch)) { > warn "AddReturn error: branch '$branch' not found. Reverting to " . C4::Context->userenv->{'branch'}; > undef $branch; >@@ -1757,6 +1758,7 @@ routine in C<C4::Accounts>. > > sub MarkIssueReturned { > my ( $borrowernumber, $itemnumber, $dropbox_branch, $returndate, $privacy ) = @_; >+ > my $dbh = C4::Context->dbh; > my $query = 'UPDATE issues SET returndate='; > my @bind; >@@ -3092,12 +3094,13 @@ sub LostItem{ > > # if a borrower lost the item, add a replacement cost to the their record > if ( my $borrowernumber = $issues->{borrowernumber} ){ >- >+ my $borrower = C4::Members::GetMemberDetails( $borrowernumber ); >+ > C4::Accounts::chargelostitem($borrowernumber, $itemnumber, $issues->{'replacementprice'}, "Lost Item $issues->{'title'} $issues->{'barcode'}") > if $charge_fee; > #FIXME : Should probably have a way to distinguish this from an item that really was returned. > #warn " $issues->{'borrowernumber'} / $itemnumber "; >- MarkIssueReturned($borrowernumber,$itemnumber) if $mark_returned; >+ MarkIssueReturned($borrowernumber,$itemnumber,undef,undef,$borrower->{'privacy'}) if $mark_returned; > } > } > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8005
:
9293
|
10013