Bugzilla – Attachment 92939 Details for
Bug 23526
Shibboleth login url with query has double encoded '?' %3F
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23526: Don't use encoded question mark in shib_login_url
Bug-23526-Dont-use-encoded-question-mark-in-shiblo.patch (text/plain), 1.08 KB, created by
Matthias Meusburger
on 2019-09-18 13:23:50 UTC
(
hide
)
Description:
Bug 23526: Don't use encoded question mark in shib_login_url
Filename:
MIME Type:
Creator:
Matthias Meusburger
Created:
2019-09-18 13:23:50 UTC
Size:
1.08 KB
patch
obsolete
>From cfeef21a3bcdde641f4675defdf148666887f467 Mon Sep 17 00:00:00 2001 >From: Nick <nick@bywatersolutions.com> >Date: Tue, 10 Sep 2019 14:04:43 +0000 >Subject: [PATCH] Bug 23526: Don't use encoded question mark in shib_login_url > >To test: >1 - Enable shib >2 - Do a search >3 - Try to login from search >4 - Get an error >5 - Apply patch >6 - Retry > >Note: You don't haveto really enable shib, you can simply enable it in koha-conf.xml and check the URLs >Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> >--- > C4/Auth_with_shibboleth.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Auth_with_shibboleth.pm b/C4/Auth_with_shibboleth.pm >index bb0a342..55cee73 100644 >--- a/C4/Auth_with_shibboleth.pm >+++ b/C4/Auth_with_shibboleth.pm >@@ -63,7 +63,7 @@ sub login_shib_url { > > my $param = _get_uri() . get_script_name(); > if ( $query->query_string() ) { >- $param = $param . '%3F' . $query->query_string(); >+ $param = $param . '?' . $query->query_string(); > } > my $uri = _get_uri() . "/Shibboleth.sso/Login?target=$param"; > return $uri; >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23526
:
92699
| 92939