Attachment 92981 Details for Bug 22837 – Bug 22837: Update apply to accept an arrayref

[patch] Bug 22837: Update apply to accept an arrayref

Bug-22837-Update-apply-to-accept-an-arrayref.patch (text/plain), 1.07 KB, created by Tomás Cohen Arazi (tcohen) on 2019-09-19 18:59:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-09-19 18:59:11 UTC

Size: 1.07 KB

patch

obsolete

>From d6c1aa7336c80a87a453700ad9f36b76c7cb5332 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 3 May 2019 12:59:16 +0100
>Subject: [PATCH] Bug 22837: Update apply to accept an arrayref
>
>This patch update the signature of Koha::Account::Line->apply to accept
>an arrayref of debits to apply against a credit instead of requireing a
>Koha::Objects set.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/Account/Line.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm
>index f4f9498ee1..f745dc13e2 100644
>--- a/Koha/Account/Line.pm
>+++ b/Koha/Account/Line.pm
>@@ -204,7 +204,7 @@ sub apply {
>     my $schema = Koha::Database->new->schema;
> 
>     $schema->txn_do( sub {
>-        while ( my $debit = $debits->next ) {
>+        for my $debit ( @{$debits} ) {
> 
>             unless ( $debit->is_debit ) {
>                 Koha::Exceptions::Account::IsNotDebit->throw(
>-- 
>2.23.0

Actions: View | Diff | Splinter Review

Attachments on bug 22837: 89314 | 89315 | 89316 | 89317 | 89468 | 89469 | 92972 | 92973 | 92977 | 92978 | 92979 | 92980 | 92981 | 92982 | 92983 | 92984