Attachment 93031 Details for Bug 23321 – Bug 23321: (QA follow-up) Make atomic update idempotent

[patch] Bug 23321: (QA follow-up) Make atomic update idempotent

Bug-23321-QA-follow-up-Make-atomic-update-idempote.patch (text/plain), 3.01 KB, created by Tomás Cohen Arazi (tcohen) on 2019-09-20 19:02:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-09-20 19:02:47 UTC

Size: 3.01 KB

patch

obsolete

>From 889ffea07a1258c6dd1f7b09fd0e17501450d493 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 20 Sep 2019 15:06:38 -0300
>Subject: [PATCH] Bug 23321: (QA follow-up) Make atomic update idempotent
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> .../data/mysql/atomicupdate/bug_23321.perl    | 30 ++++++++++---------
> 1 file changed, 16 insertions(+), 14 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_23321.perl b/installer/data/mysql/atomicupdate/bug_23321.perl
>index 9ddf9c6199..0aff6a8a37 100644
>--- a/installer/data/mysql/atomicupdate/bug_23321.perl
>+++ b/installer/data/mysql/atomicupdate/bug_23321.perl
>@@ -1,20 +1,22 @@
> $DBversion = 'XXX';    # will be replaced by the RM
> if ( CheckVersion($DBversion) ) {
> 
>-    $dbh->do(qq{
>-CREATE TABLE `cash_registers` (
>-  `id` int(11) NOT NULL auto_increment, -- unique identifier for each account register
>-  `name` varchar(24) NOT NULL, -- the user friendly identifier for each account register
>-  `description` longtext NOT NULL, -- the user friendly description for each account register
>-  `branch` varchar(10) NOT NULL, -- the foreign key the library this account register belongs
>-  `branch_default` tinyint(1) NOT NULL DEFAULT 0, -- boolean flag to denote that this till is the branch default
>-  `starting_float` decimal(28, 6), -- the starting float this account register should be assigned
>-  `archived` tinyint(1) NOT NULL DEFAULT 0, -- boolean flag to denote if this till is archived or not
>-  PRIMARY KEY (`id`),
>-  UNIQUE KEY `name` (`name`,`branch`),
>-  CONSTRAINT cash_registers_branch FOREIGN KEY (branch) REFERENCES branches (branchcode) ON UPDATE CASCADE ON DELETE CASCADE
>-) ENGINE = InnoDB DEFAULT CHARSET = utf8mb4 COLLATE = utf8mb4_unicode_ci;
>-    });
>+    unless ( TableExists( 'cash_registers' ) ) {
>+        $dbh->do(qq{
>+    CREATE TABLE `cash_registers` (
>+    `id` int(11) NOT NULL auto_increment, -- unique identifier for each account register
>+    `name` varchar(24) NOT NULL, -- the user friendly identifier for each account register
>+    `description` longtext NOT NULL, -- the user friendly description for each account register
>+    `branch` varchar(10) NOT NULL, -- the foreign key the library this account register belongs
>+    `branch_default` tinyint(1) NOT NULL DEFAULT 0, -- boolean flag to denote that this till is the branch default
>+    `starting_float` decimal(28, 6), -- the starting float this account register should be assigned
>+    `archived` tinyint(1) NOT NULL DEFAULT 0, -- boolean flag to denote if this till is archived or not
>+    PRIMARY KEY (`id`),
>+    UNIQUE KEY `name` (`name`,`branch`),
>+    CONSTRAINT cash_registers_branch FOREIGN KEY (branch) REFERENCES branches (branchcode) ON UPDATE CASCADE ON DELETE CASCADE
>+    ) ENGINE = InnoDB DEFAULT CHARSET = utf8mb4 COLLATE = utf8mb4_unicode_ci;
>+        });
>+    }
> 
>     unless ( column_exists( 'accountlines', 'register_id' ) ) {
>         $dbh->do(qq{ALTER TABLE `accountlines` ADD `register_id` int(11) NULL DEFAULT NULL AFTER `manager_id`});
>-- 
>2.23.0

Actions: View | Diff | Splinter Review

Attachments on bug 23321: 91596 | 91597 | 91598 | 91599 | 91600 | 91601 | 91602 | 91621 | 92057 | 92058 | 92059 | 92060 | 92061 | 92062 | 92063 | 92064 | 92065 | 92083 | 92084 | 92085 | 92086 | 92087 | 92088 | 92089 | 92090 | 92091 | 92394 | 92395 | 92396 | 92397 | 92398 | 92399 | 92400 | 92401 | 92402 | 92467 | 92468 | 92469 | 92470 | 92471 | 92472 | 92473 | 92474 | 92475 | 92803 | 92804 | 92805 | 92806 | 92807 | 92808 | 92809 | 92810 | 92811 | 92812 | 92813 | 92814 | 92829 | 92879 | 92880 | 92881 | 92882 | 92883 | 92884 | 92885 | 92886 | 92887 | 92888 | 92889 | 93019 | 93020 | 93021 | 93022 | 93023 | 93024 | 93025 | 93026 | 93027 | 93028 | 93029 | 93030 | 93031 | 93032 | 93033 | 93034 | 93035 | 93188