Bugzilla – Attachment 93085 Details for
Bug 23663
Itemtype summary feature in search results is only used in deprecated opac results non-xslt view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23663: Only process itemtype summary if using non-xslt opac results
Bug-23663-Only-process-itemtype-summary-if-using-n.patch (text/plain), 1.67 KB, created by
Nick Clemens (kidclamp)
on 2019-09-21 11:39:10 UTC
(
hide
)
Description:
Bug 23663: Only process itemtype summary if using non-xslt opac results
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-09-21 11:39:10 UTC
Size:
1.67 KB
patch
obsolete
>From 8d6bc2100e06ec6201efbd9bdb74fc9bf1f2d59b Mon Sep 17 00:00:00 2001 >From: Nick <nick@bywatersolutions.com> >Date: Sat, 21 Sep 2019 11:33:47 +0000 >Subject: [PATCH] Bug 23663: Only process itemtype summary if using non-xslt > opac results > >To test: >1 - Set OpacXSLTResultsDisplay to "" to use non-xslt view >2 - In Administration->Itemtypes define a summary for an itemtype: > This is the summary for [245a] >3 - Perform a search on the opac that will return results with this itemtype >4 - Note "This is the summary" appears in results with the title >5 - Set OPACXSLTResultsDisplay to 'default' >6 - Refresh your search results, note the summary disappears >7 - Try search in other places and note that summary never appears >8 - Apply patch >9 - Repeat 1-7 and note nothing changed >--- > C4/Search.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index 65f514498f..81437f0173 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -1953,8 +1953,9 @@ sub searchResults { > $oldbiblio->{edition} = $oldbiblio->{editionstatement}; > $oldbiblio->{description} = $itemtypes{ $oldbiblio->{itemtype} }->{translated_description}; > # Build summary if there is one (the summary is defined in the itemtypes table) >- # FIXME: is this used anywhere, I think it can be commented out? -- JF >- if ( $itemtypes{ $oldbiblio->{itemtype} }->{summary} ) { >+ >+ # FIXME: this is only used in the deprecated non-XLST opac results >+ if ( !$xslfile && $is_opac && $itemtypes{ $oldbiblio->{itemtype} }->{summary} ) { > my $summary = $itemtypes{ $oldbiblio->{itemtype} }->{summary}; > my @fields = $marcrecord->fields(); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23663
:
93085
|
93135
|
94827