Bugzilla – Attachment 93125 Details for
Bug 22280
The ILL module assumes every status needs a next/previous status
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22280: Fix typo in _status_graph_union
Bug-22280-Fix-typo-in-statusgraphunion.patch (text/plain), 1.53 KB, created by
Andrew Isherwood
on 2019-09-23 15:34:55 UTC
(
hide
)
Description:
Bug 22280: Fix typo in _status_graph_union
Filename:
MIME Type:
Creator:
Andrew Isherwood
Created:
2019-09-23 15:34:55 UTC
Size:
1.53 KB
patch
obsolete
>From 9a0420e7b605cc964dddfc457ce6457308e077b0 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 3 Jul 2019 15:34:48 -0300 >Subject: [PATCH] Bug 22280: Fix typo in _status_graph_union > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >--- > Koha/Illrequest.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm >index 1ca2991628..73e590acc1 100644 >--- a/Koha/Illrequest.pm >+++ b/Koha/Illrequest.pm >@@ -529,7 +529,7 @@ sub _status_graph_union { > $status_graph->{$backend_status_key} = $backend_status; > # Update all core methods' next_actions. > foreach my $prev_action ( @{$backend_status->{prev_actions}} ) { >- if ( grep $prev_action, @core_status_ids ) { >+ if ( grep { $prev_action eq $_ } @core_status_ids ) { > my @next_actions = > @{$status_graph->{$prev_action}->{next_actions}}; > push @next_actions, $backend_status_key; >@@ -539,7 +539,7 @@ sub _status_graph_union { > } > # Update all core methods' prev_actions > foreach my $next_action ( @{$backend_status->{next_actions}} ) { >- if ( grep $next_action, @core_status_ids ) { >+ if ( grep { $next_action eq $_ } @core_status_ids ) { > my @prev_actions = > @{$status_graph->{$next_action}->{prev_actions}}; > push @prev_actions, $backend_status_key; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22280
:
91232
|
93125
|
93127
|
93128
|
93354