Attachment 93145 Details for Bug 18710 – Bug 18710 - Wrong subfield modified in batch item modification

[patch] Bug 18710 - Wrong subfield modified in batch item modification

Bug-18710---Wrong-subfield-modified-in-batch-item-.patch (text/plain), 2.55 KB, created by Nick Clemens (kidclamp) on 2019-09-24 17:36:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-09-24 17:36:13 UTC

Size: 2.55 KB

patch

obsolete

>From d53f752d26cfc7f2f884ad36b26fbc4bae25aea9 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Wed, 31 May 2017 16:54:32 +0200
>Subject: [PATCH] Bug 18710 - Wrong subfield modified in batch item
> modification
>
>In Tools > Batch item modification, one can modify or delete a subfield.
>When deleting a subfield et modifying another, the wrong subfield gets modified.
>
>This is caused by the fact that disabled inputs are not posted in form.
>So for a subfield to delete :
>Input name=field_value is not posted. But input name=subfield is posted with subfield code.
>So these 2 arrays does not have the same size :
>    my @subfields = $input->multi_param('subfield');
>    my @values    = $input->multi_param('field_value');
>
>For exemple, deleting $2, not changing $u and modidying $v will modify $u with value for $v o_O
>
>This patch correts but setting disabled all inputs of a deleted subfield : field_value, tag, subfield and mandatory. Like it was not present in the form.
>
>Test plan :
>- Go to Tools > Batch item modification
>- Enter a barcode and submit
>- Lets say there are subfields : $2 (not mandatory), $u and $v
>- Check the subfield $2 to be deleted
>=> $2 input is disabled
>- Enter a text in $v
>- Submit the form
>=> Without patch, the text for $v gets into $u
>=> With patch, the text for $v gets into $v
>- Check the subfield $2 is well deleted
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>index 968770d323..61331ba73e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>@@ -23,12 +23,12 @@ $(document).ready(function(){
>   $("input[name='disable_input']").click(function() {
>       var row = $(this).attr("id");
>       row = row.replace("row","hint");
>-      var editor = $(this).parent().find("[name='field_value']");
>+      var todisable = $(this).parent().find("[name='field_value'],[name='tag'],[name='subfield'],[name='mandatory']");
>       if ($(this).is(":checked")) {
>-          $(editor).prop('disabled', true);
>+          $(todisable).prop('disabled', true);
>           $("#"+row).html(_("This subfield will be deleted"));
>       } else {
>-          $(editor).prop('disabled', false);
>+          $(todisable).prop('disabled', false);
>           $("#"+row).html("");
>       }
>   });
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 18710: 63879 | 63880 | 93145 | 93179