Bugzilla – Attachment 93165 Details for
Bug 23679
Software error when trying to transfer an unknown barcode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23679: fix software error when trying to transfer an unknown barcode
Bug-23679-fix-software-error-when-trying-to-transf.patch (text/plain), 1.23 KB, created by
Fridolin Somers
on 2019-09-26 07:15:09 UTC
(
hide
)
Description:
Bug 23679: fix software error when trying to transfer an unknown barcode
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2019-09-26 07:15:09 UTC
Size:
1.23 KB
patch
obsolete
>From 3bd166d1a0b0490d8505eb5af726614c72df1bf3 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 26 Sep 2019 09:09:15 +0200 >Subject: [PATCH] Bug 23679: fix software error when trying to transfer an > unknown barcode > >When trying to transfer an unknown barcode in /cgi-bin/koha/circ/branchtransfers.pl you get the error : > >Can't call method "itemnumber" on an undefined value at /home/koha/src/C4/Circulation.pm line 319. > >This comes from C4::Circulation::transferbook which should stop when finding unknown barcode. > >Test plan : >1) Go to /cgi-bin/koha/circ/branchtransfers.pl >2) Enter a barcode not existing in database >3) Without patch you get a software error, with patch you get a message saying 'No Item with barcode' >4) Enter a barcode existing in database and check transfer is OK >--- > C4/Circulation.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 66993ea461..014c018628 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -314,6 +314,7 @@ sub transferbook { > unless ( $item ) { > $messages->{'BadBarcode'} = $barcode; > $dotransfer = 0; >+ return ( $dotransfer, $messages ); > } > > my $itemnumber = $item->itemnumber; >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23679
:
93164
|
93165
|
93198
|
93199
|
93211
|
93212
|
93213
|
93214
|
93235
|
93236