Attachment 93189 Details for Bug 23688 – Bug 23688 - System preference uppercasesurnames broken by typo

[patch] Bug 23688 - System preference uppercasesurnames broken by typo

Bug-23688---System-preference-uppercasesurnames-br.patch (text/plain), 2.06 KB, created by Kyle M Hall (khall) on 2019-09-27 11:25:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2019-09-27 11:25:01 UTC

Size: 2.06 KB

patch

obsolete

>From fdf679cff5bcd370aa0356feeb0134eb9da9a4ff Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 27 Sep 2019 07:23:28 -0400
>Subject: [PATCH] Bug 23688 - System preference uppercasesurnames broken by
> typo
>
>In the process of moving this feature from memberentry.pl to Patron.pm, the 's' on uppercasesurnames was dropped, breaking the feature.
>
>Test Plan:
>1) Test uppercasesurnames, note it does not work
>2) Apply this patch
>3) Test uppercasesurnames, note it works now!
>---
> Koha/Patron.pm                | 2 +-
> t/db_dependent/Koha/Patrons.t | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 436120e0e6..fca796ff28 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -196,7 +196,7 @@ sub store {
> 
>             # Set surname to uppercase if uppercasesurname is true
>             $self->surname( uc($self->surname) )
>-                if C4::Context->preference("uppercasesurname");
>+                if C4::Context->preference("uppercasesurnames");
> 
>             unless ( $self->in_storage ) {    #AddMember
> 
>diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t
>index c8d01188ac..4d7063c497 100644
>--- a/t/db_dependent/Koha/Patrons.t
>+++ b/t/db_dependent/Koha/Patrons.t
>@@ -1704,13 +1704,13 @@ subtest '->store' => sub {
>     $patron_1->surname('xxx')->store;
>     is( $patron_1->password, $digest, 'Password should not have changed on ->store');
> 
>-    # Test uppercasesurname
>-    t::lib::Mocks::mock_preference( 'uppercasesurname', 1 );
>+    # Test uppercasesurnames
>+    t::lib::Mocks::mock_preference( 'uppercasesurnames', 1 );
>     my $surname = lc $patron_1->surname;
>     $patron_1->surname($surname)->store;
>     isnt( $patron_1->surname, $surname,
>         'Surname converts to uppercase on store.');
>-    t::lib::Mocks::mock_preference( 'uppercasesurname', 0 );
>+    t::lib::Mocks::mock_preference( 'uppercasesurnames', 0 );
>     $patron_1->surname($surname)->store;
>     is( $patron_1->surname, $surname,
>         'Surname remains unchanged on store.');
>-- 
>2.21.0 (Apple Git-122)

Actions: View | Diff | Splinter Review

Attachments on bug 23688: 93189 | 93210 | 93237