Attachment 93206 Details for Bug 23689 – Bug 23689: Fix terminology for branches limitations on authorized values

[patch] Bug 23689: Fix terminology for branches limitations on authorized values

Bug-23689-Fix-terminology-for-branches-limitations.patch (text/plain), 2.48 KB, created by Martin Renvoize (ashimema) on 2019-09-27 14:01:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-09-27 14:01:25 UTC

Size: 2.48 KB

patch

obsolete

>From c0b340481e5a6c4d6ce1e22c76543b1554427955 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 27 Sep 2019 14:41:51 +0100
>Subject: [PATCH] Bug 23689: Fix terminology for branches limitations on
> authorized values
>
>This patch corrects the terminology and also updates the tooltip to use
>the current bootstrap tooltip library.
>---
> .../prog/en/modules/admin/authorised_values.tt    | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>index e62749a5bc..50392e8986 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>@@ -215,7 +215,7 @@
>         <th>Description</th>
>         <th>Description (OPAC)</th>
>         <th>Icon</th>
>-        <th>Branches limitations</th>
>+        <th>Library limitations</th>
>         <th>Actions</th>
>         </tr>
>     </thead><tbody>
>@@ -229,13 +229,17 @@
>             [% IF loo.branches.size > 0 %]
>                 [% branches_str = "" %]
>                 [% FOREACH branch IN loo.branches %]
>-                    [% branches_str = branches_str _ " " _ branch.branchname _ "(" _ branch.branchcode _ ")" %]
>+                    [%- IF loop.first -%]
>+                    [% branches_str = branch.branchname _ " (" _ branch.branchcode _ ")" %]
>+                    [% ELSE %]
>+                    [% branches_str = branches_str _ "\n" _ branch.branchname _ " (" _ branch.branchcode _ ")" %]
>+                    [% END %]
>                 [% END %]
>-                <span href="#" title="[% branches_str | html %]">
>+                <span class="library_limitation" title="[% branches_str | html %]">
>                     [% IF loo.branches.size > 1 %]
>-                        [% loo.branches.size | html %] branches limitations
>+                        [% loo.branches.size | html %] library limitations
>                     [% ELSE %]
>-                        [% loo.branches.size | html %] branch limitation
>+                        [% loo.branches.size | html %] library limitation
>                     [% END %]
>             [% ELSE %]
>                 No limitation
>@@ -320,6 +324,7 @@
>             $('#searchfield').change(function() {
>                 $('#category').submit();
>             });
>+            $(".library_limitation").tooltip();
>         });
>     </script>
> [% END %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23689: 93206 | 93207 | 93243 | 93245 | 93246