Bugzilla – Attachment 93412 Details for
Bug 23382
Issuing rules failing after bug 20912
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23382: (follow-up) Ensure tests pass on Wednesdays
Bug-23382-follow-up-Ensure-tests-pass-on-Wednesday.patch (text/plain), 1.79 KB, created by
Martin Renvoize (ashimema)
on 2019-10-02 10:21:51 UTC
(
hide
)
Description:
Bug 23382: (follow-up) Ensure tests pass on Wednesdays
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-10-02 10:21:51 UTC
Size:
1.79 KB
patch
obsolete
>From 0e803d9c3c82c69a6ac5b2abe17542bdb7aa668a Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 2 Oct 2019 11:20:27 +0100 >Subject: [PATCH] Bug 23382: (follow-up) Ensure tests pass on Wednesdays > >--- > t/db_dependent/Circulation.t | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index be906abd7d..a5f12d8ced 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -3348,8 +3348,9 @@ subtest 'Incremented fee tests' => sub { > is( $itemtype->rentalcharge_hourly, > '2.500000', 'Hourly rental charge stored and retreived correctly' ); > >- $dt_to = dt_from_string()->add( hours => 4 ); >- $dt_to_renew = dt_from_string()->add( hours => 6 ); >+ $dt_to = dt_from_string()->add( hours => 4, minutes => 30 ); >+ $dt_to_renew = dt_from_string()->add( hours => 6, minutes => 30 ); >+ $calendar->delete_holiday( weekday => 3); > > $issue = > AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from ); >@@ -3416,7 +3417,7 @@ subtest 'CanBookBeIssued & RentalFeesCheckoutConfirmation' => sub { > > $itemtype->rentalcharge('1.000000')->store; > ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef ); >- is_deeply( $needsconfirmation, { RENTALCHARGE => '1' }, 'Item needs rentalcharge confirmation to be issued' ); >+ is_deeply( $needsconfirmation, { RENTALCHARGE => '1.00' }, 'Item needs rentalcharge confirmation to be issued' ); > $itemtype->rentalcharge('0')->store; > $itemtype->rentalcharge_daily('1.000000')->store; > ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23382
:
92221
|
92222
|
92236
|
92237
|
92238
|
92273
|
92274
|
92275
|
92276
|
93407
|
93408
|
93409
|
93410
|
93411
|
93412
|
94281
|
94282
|
94283
|
94284
|
94285
|
94286
|
94287
|
94288
|
94289
|
94723
|
94724
|
94725
|
94726
|
94727
|
94728
|
94729
|
94730
|
94731
|
94743
|
94755
|
94756
|
94757
|
94758
|
94759
|
94760
|
94761
|
94762
|
94763
|
94764
|
94765
|
94766
|
94774
|
94775
|
94776
|
94777
|
94778
|
94779
|
94780
|
94781
|
94782
|
94783
|
94784
|
107456
|
107457