Attachment 93441 Details for Bug 23712 – Bug 23712 - Silence warns from Koha/Illrequest/Logger.pm

[patch] Bug 23712 - Silence warns from Koha/Illrequest/Logger.pm

Bug-23712---Silence-warns-from-KohaIllrequestLogge.patch (text/plain), 1.27 KB, created by Brendan Gallagher on 2019-10-02 12:05:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Gallagher

Created: 2019-10-02 12:05:13 UTC

Size: 1.27 KB

patch

obsolete

>From e9294f669ae95d44b5c05f6f0637a9f96928c668 Mon Sep 17 00:00:00 2001
>From: Magnus Enger <magnus@libriotech.no>
>Date: Tue, 1 Oct 2019 16:41:31 +0200
>Subject: [PATCH] Bug 23712 - Silence warns from Koha/Illrequest/Logger.pm
>
>To test:
>- Run: $ sudo koha-shell -c "prove t/db_dependent/Illrequests.t" kohadev
>- Observe the warnings about "no query in themelanguage"
>- Apply the patch
>- Run prove again
>- Observe the lack of warnings about "no query in themelanguage"
>  (There will be a couple of other warnings, but they are not
>  related to the present bug.)
>
>Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
>---
> Koha/Illrequest/Logger.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Illrequest/Logger.pm b/Koha/Illrequest/Logger.pm
>index 0625370237..bdd4e8f5ff 100644
>--- a/Koha/Illrequest/Logger.pm
>+++ b/Koha/Illrequest/Logger.pm
>@@ -65,8 +65,9 @@ sub new {
>         }
>     };
> 
>+    my $query = new CGI; # To keep C4::Templates::_get_template_file() from complaining
>     my ( $htdocs, $theme, $lang, $base ) =
>-        C4::Templates::_get_template_file('ill/log/', 'intranet');
>+        C4::Templates::_get_template_file('ill/log/', 'intranet', $query);
> 
>     $self->{templates} = {
>         STATUS_CHANGE => $base . 'status_change.tt'
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23712: 93376 | 93441 | 94407 | 94408