Bugzilla – Attachment 93551 Details for
Bug 23723
Using exit inside eval to stop sending output to the browser doesn't work under Plack
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack
BZ23723.patch (text/plain), 1.06 KB, created by
Theodoros Theodoropoulos
on 2019-10-03 10:08:27 UTC
(
hide
)
Description:
Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack
Filename:
MIME Type:
Creator:
Theodoros Theodoropoulos
Created:
2019-10-03 10:08:27 UTC
Size:
1.06 KB
patch
obsolete
>diff --git a/members/discharge.pl b/members/discharge.pl >index db74cfc..9e530bf 100755 >--- a/members/discharge.pl >+++ b/members/discharge.pl >@@ -90,11 +90,13 @@ if ( $input->param('discharge') and $can_be_discharged ) { > my @lines = <$fh>; > close $fh; > print @lines; >- exit; > }; > if ( $@ ) { > carp $@; > $template->param( messages => [ {type => 'error', code => 'unable_to_generate_pdf'} ] ); >+ } else { >+ # no error, pdf is sent, so stop sending data to browser >+ exit; > } > } > >diff --git a/opac/opac-discharge.pl b/opac/opac-discharge.pl >index 4e8381b..75b6af8 100755 >--- a/opac/opac-discharge.pl >+++ b/opac/opac-discharge.pl >@@ -99,11 +99,13 @@ elsif ( $op eq 'get' ) { > my @lines = <$fh>; > close $fh; > print @lines; >- exit; > }; > if ( $@ ) { > carp $@; > $template->param( messages => [ {type => 'error', code => 'unable_to_generate_pdf'} ] ); >+ } else { >+ # no error, pdf is sent, so stop sending data to browser >+ exit; > } > } > else { >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23723
:
93527
|
93541
|
93551
|
93552
|
93556
|
93580