Bugzilla – Attachment 93668 Details for
Bug 22294
EDI wrongly assumes all ISBN13's have corresponding ISBN10's
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22294: Check return of as_isbn10 before calling methods on it
Bug-22294-Check-return-of-asisbn10-before-calling-.patch (text/plain), 889 bytes, created by
Brendan Gallagher
on 2019-10-04 07:49:00 UTC
(
hide
)
Description:
Bug 22294: Check return of as_isbn10 before calling methods on it
Filename:
MIME Type:
Creator:
Brendan Gallagher
Created:
2019-10-04 07:49:00 UTC
Size:
889 bytes
patch
obsolete
>From b6a71fe28fa383b739da434455cff0715945c376 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 8 Feb 2019 10:37:50 +0000 >Subject: [PATCH] Bug 22294: Check return of as_isbn10 before calling methods > on it > >Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> >--- > Koha/EDI.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/EDI.pm b/Koha/EDI.pm >index 4e730de286..54edf00aa7 100644 >--- a/Koha/EDI.pm >+++ b/Koha/EDI.pm >@@ -898,7 +898,7 @@ sub _check_for_existing_bib { > $isbn =~ s/\-//xmsg; > if ( $isbn =~ m/(\d{13})/xms ) { > my $b_isbn = Business::ISBN->new($1); >- if ( $b_isbn && $b_isbn->is_valid ) { >+ if ( $b_isbn && $b_isbn->is_valid && $b_isbn->as_isbn10 ) { > $search_isbn = $b_isbn->as_isbn10->as_string( [] ); > } > >-- >2.11.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=93668">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22294
:
84861
|
93668
|
93755