Bugzilla – Attachment 93728 Details for
Bug 23484
Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23484: Update pendingreserves.pl to use circulation_rules
Bug-23484-Update-pendingreservespl-to-use-circulat.patch (text/plain), 1.64 KB, created by
Fridolin Somers
on 2019-10-04 10:00:06 UTC
(
hide
)
Description:
Bug 23484: Update pendingreserves.pl to use circulation_rules
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2019-10-04 10:00:06 UTC
Size:
1.64 KB
patch
obsolete
>From 9f45bdd86e95fcaacf79c341e26143177490a1e5 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 21 Aug 2019 13:39:14 +0000 >Subject: [PATCH] Bug 23484: Update pendingreserves.pl to use circulation_rules > >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> >--- > circ/pendingreserves.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index d890673490..983bfdf41f 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -214,7 +214,7 @@ my $strsth = > LEFT JOIN branchtransfers ON items.itemnumber=branchtransfers.itemnumber > LEFT JOIN issues ON items.itemnumber=issues.itemnumber > LEFT JOIN borrowers ON reserves.borrowernumber=borrowers.borrowernumber >- LEFT JOIN default_branch_item_rules ON items.itype=default_branch_item_rules.itemtype >+ LEFT JOIN circulation_rules ON items.itype=circulation_rules.itemtype AND rule_name = 'holdallowed' AND circulation_rules.branchcode IS NULL AND circulation_rules.categorycode IS NULL > WHERE > reserves.found IS NULL > $sqldatewhere >@@ -225,7 +225,7 @@ my $strsth = > AND reserves.priority <> 0 > AND reserves.suspend = 0 > AND notforloan = 0 AND itemlost = 0 AND withdrawn = 0 >- AND ( default_branch_item_rules.holdallowed IS NULL OR default_branch_item_rules.holdallowed != 0 ) >+ AND ( circulation_rules.rule_value IS NULL OR circulation_rules.rule_value != 0 ) > "; > # GROUP BY reserves.biblionumber allows only items that are not checked out, else multiples occur when > # multiple patrons have a hold on an item >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23484
:
92403
|
93728
|
93731
|
93985
|
93986