Bugzilla – Attachment 93787 Details for
Bug 23612
If no columns in a table can be toggled, don't show columns button
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23612: (RM follow-up) Fix failing tests
Bug-23612-RM-follow-up-Fix-failing-tests.patch (text/plain), 2.26 KB, created by
Martin Renvoize (ashimema)
on 2019-10-07 10:03:48 UTC
(
hide
)
Description:
Bug 23612: (RM follow-up) Fix failing tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-10-07 10:03:48 UTC
Size:
2.26 KB
patch
obsolete
>From 43519c0525a07b8f784fd9166eb0db3430e29042 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 4 Oct 2019 13:19:18 +0100 >Subject: [PATCH] Bug 23612: (RM follow-up) Fix failing tests > >Trailing comma's were causing hidden javascript errors during selenium >tests. > >Error was identified by adding a $s->capture($driver) line to the >relevant selenium test and using the following JS snippet to dump errors >to the screen. > > (function () { > var ul = null; > function createErrorList() { > ul = document.createElement('ul'); > ul.setAttribute('id', 'js_error_list'); > //ul.style.display = 'none'; > document.body.appendChild(ul); > } > window.onerror = function(msg){ > if (ul === null) > createErrorList(); > var li = document.createElement("li"); > li.appendChild(document.createTextNode(msg)); > ul.appendChild(li); > }; > })(); > >Which clearly showed the following error. > > ReferenceError: KohaTable is not defined > >Removing the trailing comma's introduced in this bug resolved the issue. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../intranet-tmpl/prog/en/includes/columns_settings.inc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >index a5c5e0c8c6..f02ad89151 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc >@@ -69,7 +69,7 @@ function KohaTable(id_selector, dt_parameters, columns_settings, add_filters) { > dt.search( "" ).draw("page"); > node.addClass("disabled"); > } >- }, >+ } > ]; > > if( included_ids.length > 0 ){ >@@ -83,8 +83,8 @@ function KohaTable(id_selector, dt_parameters, columns_settings, add_filters) { > text: '<i class="fa fa-lg fa-gear"></i> <span class="dt-button-text">' + _("Columns") + '</span>', > exportOptions: { > columns: exportColumns >- }, >- }, >+ } >+ } > ); > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23612
:
92818
|
92865
|
93457
| 93787