Attachment 93820 Details for Bug 23762 – Bug 23762 - Editing is_html status of email template fails under multi-languages

[patch] Bug 23762 - Editing is_html status of email template fails under multi-languages

Bug-23762---Editing-ishtml-status-of-email-templat.patch (text/plain), 3.25 KB, created by Bin Wen on 2019-10-07 13:03:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bin Wen

Created: 2019-10-07 13:03:43 UTC

Size: 3.25 KB

patch

obsolete

>From 19758f76e53ede531f3b10f45cb247fc4c3e7a95 Mon Sep 17 00:00:00 2001
>From: Bin Wen <bin.wen@inlibro.com>
>Date: Mon, 7 Oct 2019 09:01:39 -0400
>Subject: [PATCH] Bug 23762 - Editing is_html status of email template fails
> under multi-languages
>
>To test:
>1.Enable multi-languages
>2.Set the preference 'TranslateNotices' on  'Allow'
>3.Go to: tools==>Notices & slips==>Edit (one notice)
>4.Click on the "Email" in the "Default" tab, change the checkbox status of 'HTML Messages'.
>5.Save
>6.Reopen the notice, nothing changed.
>7.Apply the patch
>8.Repeat the steps 4 and 5
>9.Success.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt | 4 ++--
> tools/letter.pl                                         | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>index c394f80219..0845c45b12 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
>@@ -416,9 +416,9 @@
>                                                 <input type="hidden" name="lang" value="[% lang | html %]" />
>                                                 <label for="is_html_[% letter.message_transport_type | html %]_[% lang | html %]">HTML message:</label>
>                                                 [% IF letter.is_html %]
>-                                                    <input type="checkbox" name="is_html_[% letter.message_transport_type | html %]" id="is_html_[% letter.message_transport_type | html %]_[% lang | html %]" value="1" checked="checked" />
>+                                                    <input type="checkbox" name="is_html_[% letter.message_transport_type | html %]_[% lang | html %]" id="is_html_[% letter.message_transport_type | html %]_[% lang | html %]" value="1" checked="checked" />
>                                                 [% ELSE %]
>-                                                    <input type="checkbox" name="is_html_[% letter.message_transport_type | html %]" id="is_html_[% letter.message_transport_type | html %]_[% lang | html %]" value="1" />
>+                                                    <input type="checkbox" name="is_html_[% letter.message_transport_type | html %]_[% lang | html %]" id="is_html_[% letter.message_transport_type | html %]_[% lang | html %]" value="1" />
>                                                 [% END %]
>                                             </li>
>                                             <li>
>diff --git a/tools/letter.pl b/tools/letter.pl
>index a673fa96a9..2c5481e6cd 100755
>--- a/tools/letter.pl
>+++ b/tools/letter.pl
>@@ -290,10 +290,10 @@ sub add_validate {
>     my @content       = $input->multi_param('content');
>     my @lang          = $input->multi_param('lang');
>     for my $mtt ( @mtt ) {
>-        my $is_html = $input->param("is_html_$mtt");
>+        my $lang = shift @lang;
>+        my $is_html = $input->param("is_html_$mtt\_$lang");
>         my $title   = shift @title;
>         my $content = shift @content;
>-        my $lang = shift @lang;
>         my $letter = C4::Letters::getletter( $oldmodule, $code, $branchcode, $mtt, $lang );
> 
>         # getletter can return the default letter even if we pass a branchcode
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 23762: 93820 | 93906 | 94948