Attachment 93829 Details for Bug 23768 – Bug 23768: Return invalid ISBN when searching with variations

[patch] Bug 23768: Return invalid ISBN when searching with variations

Bug-23768-Return-invalid-ISBN-when-searching-with-.patch (text/plain), 1.30 KB, created by Nick Clemens (kidclamp) on 2019-10-07 17:49:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2019-10-07 17:49:19 UTC

Size: 1.30 KB

patch

obsolete

>From 12c089f9c21ee028aef54fa99da8aff80ed75664 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 7 Oct 2019 17:46:30 +0000
>Subject: [PATCH] Bug 23768: Return invalid ISBN when searching with variations
>
>To test:
>1 - Enable SearchWithISBNVariations and  IntranetCatalogSearchPulldown
>2 - Refresh page and click on 'Search the catalog' tab
>3 - Search for 'ISBN' 0385299209
>4 - Note no results
>5 - Note the search says if searched 'kw,wrdl: (nb=)'
>6 - Apply patch, restart all the things
>7 - Repeat search
>8 - Search looks correctly formed
>9 - Add the isbn above to a record, confirm it is returned by search
>10 - Confirm searches for valid ISBNs still work as expected
>---
> C4/Koha.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Koha.pm b/C4/Koha.pm
>index 9894a060cf..dd0a165a58 100644
>--- a/C4/Koha.pm
>+++ b/C4/Koha.pm
>@@ -897,7 +897,7 @@ sub GetVariationsOfISBN {
> 
>     my @isbns;
> 
>-    push( @isbns, NormalizeISBN({ isbn => $isbn }) );
>+    push( @isbns, NormalizeISBN({ isbn => $isbn, return_invalid => 1 }) );
>     push( @isbns, NormalizeISBN({ isbn => $isbn, format => 'ISBN-10' }) );
>     push( @isbns, NormalizeISBN({ isbn => $isbn, format => 'ISBN-13' }) );
>     push( @isbns, NormalizeISBN({ isbn => $isbn, format => 'ISBN-10', strip_hyphens => 1 }) );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23768: 93829 | 94963 | 95137 | 95138