Attachment 93849 Details for Bug 22667 – Bug 22667: Pick default value from framework for cn_source

[patch] Bug 22667: Pick default value from framework for cn_source

Bug-22667-Pick-default-value-from-framework-for-cn.patch (text/plain), 1.62 KB, created by Katrin Fischer on 2019-10-07 20:19:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-10-07 20:19:47 UTC

Size: 1.62 KB

patch

obsolete

>From 84366f8e6d7534c3c7708d29d73f2e70bac20588 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 30 Apr 2019 13:54:37 -0400
>Subject: [PATCH] Bug 22667: Pick default value from framework for cn_source
>
>If the cn_source has a default value defined in the framework it will
>not be used when ordering or receiving serials.
>
>Test plan:
>Set the pref DefaultClassificationSource to Library of congress
>Define a default value=ddc (for Dewey) for the ACQ and default framework
>Receive an order (AcqCreateItem=on ordering) and confirm that Dewey is
>selected by default (the default value from the ACQ framework is used)
>Receive a serial and confirm that Dewey is selected by default
>
>Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> C4/Items.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index 0b80896400..7076674392 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -2492,7 +2492,7 @@ sub PrepareItemrecordDisplay {
>                         push @authorised_values, "" unless ( $tagslib->{$tag}->{$subfield}->{mandatory} );
> 
>                         my $class_sources = GetClassSources();
>-                        my $default_source = C4::Context->preference("DefaultClassificationSource");
>+                        my $default_source = $defaultvalue || C4::Context->preference("DefaultClassificationSource");
> 
>                         foreach my $class_source (sort keys %$class_sources) {
>                             next unless $class_sources->{$class_source}->{'used'} or
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22667: 89148 | 93540 | 93849