Bugzilla – Attachment 93879 Details for
Bug 18595
Move C4::Members::Messaging to Koha namespace
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18595: Remove references to C4::Members::Messaging
Bug-18595-Remove-references-to-C4MembersMessaging.patch (text/plain), 8.65 KB, created by
Lari Taskula
on 2019-10-08 14:31:52 UTC
(
hide
)
Description:
Bug 18595: Remove references to C4::Members::Messaging
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2019-10-08 14:31:52 UTC
Size:
8.65 KB
patch
obsolete
>From f8e43e0b5f281f93e96f2dc78a5eb3b4e18fe8bd Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@jns.fi> >Date: Thu, 27 Oct 2016 16:25:05 +0300 >Subject: [PATCH] Bug 18595: Remove references to C4::Members::Messaging >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To test: >1. grep -r 'C4::Members::Messaging' > This command should not produce any results in Koha source code after this > patch. >2. Check the pages touched by this commit >3. Try setting and viewing patron and patron category messaging preferences > >As this completes the move from C4::Members::Messaging to new Koha-objects for >messaging preferences, everything should be ready for proper testing. > >Make sure you have EnhancedMessagingPreferences system preference enabled. >Then, try creating new categories and setting default messaging preferences, >as well as editing the messaging preferences of the already existing categories. >Try adding new patrons and make sure the default patron messaging preferences >are by default the same that you set for that category. Edit already exisiting >patrons' messaging preferences and make sure changes are applied. Observe >no crash at any point, otherwise fail this patch. Don't forget to test both >intranet and OPAC. > >Finally, run unit tests: >1. prove t/db_dependent/Circulation.t >2. prove t/db_dependent/Reserves.t >3. prove t/db_dependent/Koha/Patron/Categories.t > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: David Bourgault <david.bourgault@inlibro.com> >--- > C4/Auth_with_ldap.pm | 1 - > C4/Auth_with_shibboleth.pm | 1 - > C4/Form/MessagingPreferences.pm | 3 +- > C4/Members/Messaging.pm | 95 ------------------- > C4/Message.pm | 2 +- > C4/Reserves.pm | 1 - > Koha/Patron/Category.pm | 2 - > circ/returns.pl | 1 - > misc/cronjobs/advance_notices.pl | 1 - > .../borrowers-force-messaging-defaults.pl | 1 - > opac/opac-messaging.pl | 1 - > t/Members_Messaging.t | 14 --- > 12 files changed, 2 insertions(+), 121 deletions(-) > delete mode 100644 C4/Members/Messaging.pm > delete mode 100755 t/Members_Messaging.t > >diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm >index 3d9f8a47bb..c71a5d4566 100644 >--- a/C4/Auth_with_ldap.pm >+++ b/C4/Auth_with_ldap.pm >@@ -25,7 +25,6 @@ use C4::Debug; > use C4::Context; > use C4::Members::Attributes; > use C4::Members::AttributeTypes; >-use C4::Members::Messaging; > use C4::Auth qw(checkpw_internal); > use Koha::Patrons; > use Koha::AuthUtils qw(hash_password); >diff --git a/C4/Auth_with_shibboleth.pm b/C4/Auth_with_shibboleth.pm >index c602cc25c5..cbe1d5c1f5 100644 >--- a/C4/Auth_with_shibboleth.pm >+++ b/C4/Auth_with_shibboleth.pm >@@ -24,7 +24,6 @@ use C4::Context; > use Koha::AuthUtils qw(get_script_name); > use Koha::Database; > use Koha::Patrons; >-use C4::Members::Messaging; > use Carp; > use CGI; > use List::MoreUtils qw(any); >diff --git a/C4/Form/MessagingPreferences.pm b/C4/Form/MessagingPreferences.pm >index 1559d1b79d..01e2892304 100644 >--- a/C4/Form/MessagingPreferences.pm >+++ b/C4/Form/MessagingPreferences.pm >@@ -22,7 +22,6 @@ use warnings; > > use CGI qw ( -utf8 ); > use C4::Context; >-use C4::Members::Messaging; > use C4::Debug; > use Koha::Patron::Message::Preferences; > use Koha::Patrons; >@@ -178,7 +177,7 @@ sub set_form_values { > > =head1 SEE ALSO > >-L<C4::Members::Messaging>, F<admin/categories.pl>, F<opac/opac-messaging.pl>, F<members/messaging.pl> >+L<Koha::Patron::Message::Preference>, F<admin/categories.pl>, F<opac/opac-messaging.pl>, F<members/messaging.pl> > > =head1 AUTHOR > >diff --git a/C4/Members/Messaging.pm b/C4/Members/Messaging.pm >deleted file mode 100644 >index a065636da2..0000000000 >--- a/C4/Members/Messaging.pm >+++ /dev/null >@@ -1,95 +0,0 @@ >-package C4::Members::Messaging; >- >-# Copyright (C) 2008 LibLime >-# >-# This file is part of Koha. >-# >-# Koha is free software; you can redistribute it and/or modify it >-# under the terms of the GNU General Public License as published by >-# the Free Software Foundation; either version 3 of the License, or >-# (at your option) any later version. >-# >-# Koha is distributed in the hope that it will be useful, but >-# WITHOUT ANY WARRANTY; without even the implied warranty of >-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >-# GNU General Public License for more details. >-# >-# You should have received a copy of the GNU General Public License >-# along with Koha; if not, see <http://www.gnu.org/licenses>. >- >-use strict; >-use warnings; >-use C4::Context; >- >-=head1 NAME >- >-C4::Members::Messaging - manage patron messaging preferences >- >-=head1 SYNOPSIS >- >- use C4::Members::Messaging >- >-=head1 DESCRIPTION >- >-This module lets you modify a patron's messaging preferences. >- >-=head1 TABLES >- >-=head2 message_queue >- >-The actual messages which will be sent via a cron job running >-F<misc/cronjobs/process_message_queue.pl>. >- >-=head2 message_attributes >- >-What kinds of messages can be sent? >- >-=head2 message_transport_types >- >-What transports can messages be sent vith? (email, sms, etc.) >- >-=head2 message_transports >- >-How are message_attributes and message_transport_types correlated? >- >-=head2 borrower_message_preferences >- >-What messages do the borrowers want to receive? >- >-=head2 borrower_message_transport_preferences >- >-What transport should a message be sent with? >- >-=head1 CONFIG >- >-=head2 Adding a New Kind of Message to the System >- >-=over 4 >- >-=item 1. >- >-Add a new template to the `letter` table. >- >-=item 2. >- >-Insert a row into the `message_attributes` table. >- >-=item 3. >- >-Insert rows into `message_transports` for each message_transport_type. >- >-=back >- >-=head1 SEE ALSO >- >-L<C4::Letters> >- >-=head1 AUTHOR >- >-Koha Development Team <http://koha-community.org/> >- >-Andrew Moore <andrew.moore@liblime.com> >- >-=cut >- >-1; >diff --git a/C4/Message.pm b/C4/Message.pm >index e4dafdb215..f1a0e976bd 100644 >--- a/C4/Message.pm >+++ b/C4/Message.pm >@@ -406,7 +406,7 @@ sub DESTROY { } > > =head1 SEE ALSO > >-L<C4::Circulation>, L<C4::Letters>, L<C4::Members::Messaging> >+L<C4::Circulation>, L<C4::Letters>, L<Koha::Patron::Message::Preference> > > =head1 AUTHOR > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 105b7efe06..de9d440bf5 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -31,7 +31,6 @@ use C4::Context; > use C4::Items; > use C4::Letters; > use C4::Log; >-use C4::Members::Messaging; > use C4::Members; > use Koha::Account::Lines; > use Koha::Biblios; >diff --git a/Koha/Patron/Category.pm b/Koha/Patron/Category.pm >index 1485447d91..66e4e9d74b 100644 >--- a/Koha/Patron/Category.pm >+++ b/Koha/Patron/Category.pm >@@ -20,8 +20,6 @@ use Modern::Perl; > use Carp; > use List::MoreUtils qw(any); > >-use C4::Members::Messaging; >- > use Koha::Database; > use Koha::DateUtils; > use Koha::Patron::Message::Preferences; >diff --git a/circ/returns.pl b/circ/returns.pl >index 1f60df8393..15b04544c4 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -40,7 +40,6 @@ use C4::Circulation; > use C4::Context; > use C4::Items; > use C4::Koha; # FIXME : is it still useful ? >-use C4::Members::Messaging; > use C4::Members; > use C4::Output; > use C4::Print; >diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl >index cf15adf8c4..d4be3f4949 100755 >--- a/misc/cronjobs/advance_notices.pl >+++ b/misc/cronjobs/advance_notices.pl >@@ -54,7 +54,6 @@ use C4::Biblio; > use C4::Context; > use C4::Letters; > use C4::Members; >-use C4::Members::Messaging; > use C4::Overdues; > use Koha::DateUtils; > use C4::Log; >diff --git a/misc/maintenance/borrowers-force-messaging-defaults.pl b/misc/maintenance/borrowers-force-messaging-defaults.pl >index 22cf525313..79ee601b8a 100755 >--- a/misc/maintenance/borrowers-force-messaging-defaults.pl >+++ b/misc/maintenance/borrowers-force-messaging-defaults.pl >@@ -28,7 +28,6 @@ BEGIN { > > use Koha::Script; > use C4::Context; >-use C4::Members::Messaging; > use Koha::Patrons; > use Getopt::Long; > use Pod::Usage; >diff --git a/opac/opac-messaging.pl b/opac/opac-messaging.pl >index 876a7e0c09..30e541613e 100755 >--- a/opac/opac-messaging.pl >+++ b/opac/opac-messaging.pl >@@ -27,7 +27,6 @@ use C4::Koha; > use C4::Circulation; > use C4::Output; > use C4::Members; >-use C4::Members::Messaging; > use C4::Form::MessagingPreferences; > use Koha::Patrons; > use Koha::SMS::Providers; >diff --git a/t/Members_Messaging.t b/t/Members_Messaging.t >deleted file mode 100755 >index 93950084c1..0000000000 >--- a/t/Members_Messaging.t >+++ /dev/null >@@ -1,14 +0,0 @@ >-#!/usr/bin/perl >-# >-# This Koha test module is a stub! >-# Add more tests here!!! >- >-use strict; >-use warnings; >- >-use Test::More tests => 1; >- >-BEGIN { >- use_ok('C4::Members::Messaging'); >-} >- >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18595
:
63435
|
63436
|
63437
|
63438
|
63439
|
63440
|
63441
|
63794
|
63795
|
63796
|
63797
|
63798
|
63799
|
63800
|
63813
|
63815
|
63816
|
63817
|
63818
|
63819
|
63820
|
63821
|
63822
|
63823
|
63824
|
63825
|
63826
|
63827
|
63828
|
63829
|
69441
|
69442
|
69443
|
69444
|
69445
|
69446
|
69447
|
69448
|
69449
|
69450
|
69451
|
69452
|
69453
|
69667
|
69668
|
69669
|
69670
|
69671
|
69672
|
69673
|
69674
|
93873
|
93874
|
93875
|
93876
|
93877
|
93878
|
93879
|
93880
|
93908
|
94753
|
94754
|
103444
|
103445
|
103446
|
103447
|
103448
|
103449
|
103450
|
103451
|
103452
|
110151
|
110152
|
110153
|
110154
|
110155
|
110156
|
110157
|
110158
|
110159
|
112147
|
112148
|
112149
|
112150
|
112151
|
112152
|
112153
|
112154
|
112155
|
112690
|
113126
|
113192
|
113221
|
113222
|
113769
|
146541
|
146542
|
146543
|
146544
|
146545
|
146546
|
146547
|
146548
|
146549
|
146550
|
146551
|
146552