Bugzilla – Attachment 93913 Details for
Bug 13937
Add an Elasticsearch-compatible Z39.50/SRU daemon
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13937: (QA follow-up) Fix tests.
Bug-13937-QA-follow-up-Fix-tests.patch (text/plain), 2.08 KB, created by
Ere Maijala
on 2019-10-09 11:16:20 UTC
(
hide
)
Description:
Bug 13937: (QA follow-up) Fix tests.
Filename:
MIME Type:
Creator:
Ere Maijala
Created:
2019-10-09 11:16:20 UTC
Size:
2.08 KB
patch
obsolete
>From c28f63a8eb7756a4a4307224349be5ff2baa4821 Mon Sep 17 00:00:00 2001 >From: Ere Maijala <ere.maijala@helsinki.fi> >Date: Wed, 9 Oct 2019 14:15:39 +0300 >Subject: [PATCH] Bug 13937: (QA follow-up) Fix tests. > >Checking result set size is enough to verify that proper results were returned. The check for non-existing record could have caused a range error depending of library versions. >--- > t/db_dependent/Koha/Z3950Responder/GenericSession.t | 4 +--- > t/db_dependent/Koha/Z3950Responder/ZebraSession.t | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > >diff --git a/t/db_dependent/Koha/Z3950Responder/GenericSession.t b/t/db_dependent/Koha/Z3950Responder/GenericSession.t >index 1dcf69fa60..b8d9013826 100644 >--- a/t/db_dependent/Koha/Z3950Responder/GenericSession.t >+++ b/t/db_dependent/Koha/Z3950Responder/GenericSession.t >@@ -20,7 +20,7 @@ our $child; > > subtest 'test_search' => sub { > >- plan tests => 20; >+ plan tests => 19; > > t::lib::Mocks::mock_preference('SearchEngine', 'Elasticsearch'); > >@@ -114,8 +114,6 @@ subtest 'test_search' => sub { > ok($returned2, 'Record 2 returned as MARCXML'); > is($returned2->as_xml, $marc_record_2->as_xml, 'Record 2 returned properly'); > >- is($rs->record(2), undef, 'Record 3 does not exist'); >- > # SRU protocol tests > my $base = 'http://localhost:42111'; > my $ns = 'http://docs.oasis-open.org/ns/search-ws/sruResponse'; >diff --git a/t/db_dependent/Koha/Z3950Responder/ZebraSession.t b/t/db_dependent/Koha/Z3950Responder/ZebraSession.t >index d61fcc0ee3..8e39b0b0ca 100644 >--- a/t/db_dependent/Koha/Z3950Responder/ZebraSession.t >+++ b/t/db_dependent/Koha/Z3950Responder/ZebraSession.t >@@ -18,7 +18,7 @@ our $child; > > subtest 'test_search' => sub { > >- plan tests => 9; >+ plan tests => 8; > > t::lib::Mocks::mock_preference('SearchEngine', 'Zebra'); > >@@ -114,8 +114,6 @@ subtest 'test_search' => sub { > ok ($returned2, 'Record 2 returned as MARCXML'); > is($returned2->as_xml, $marc_record_2->as_xml, 'Record 2 returned properly'); > >- is($rs->record(2), undef, 'Record 3 does not exist'); >- > cleanup(); > }; > >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13937
:
46369
|
47417
|
47418
|
47419
|
53503
|
58122
|
58125
|
58126
|
59443
|
59444
|
60735
|
60736
|
60737
|
60738
|
66943
|
66944
|
66945
|
66946
|
69139
|
82562
|
82563
|
82564
|
82565
|
82566
|
82567
|
82589
|
82590
|
82591
|
82592
|
82593
|
82594
|
82595
|
82660
|
82661
|
82662
|
82663
|
82664
|
82665
|
82666
|
82667
|
83780
|
83781
|
83782
|
83783
|
83784
|
83785
|
83786
|
83787
|
83788
|
83789
|
83951
|
83952
|
83953
|
83954
|
83955
|
83956
|
83957
|
83958
|
83959
|
84050
|
84051
|
84052
|
84053
|
84054
|
84055
|
84056
|
84057
|
84058
|
84059
|
84062
|
84063
|
84064
|
84065
|
84066
|
84067
|
84068
|
84069
|
84072
|
84073
|
85112
|
86353
|
86354
|
86355
|
86356
|
86357
|
86358
|
86359
|
86360
|
86361
|
86362
|
86363
|
86364
|
88907
|
88908
|
88909
|
88910
|
88911
|
88912
|
88913
|
88914
|
88915
|
88916
|
88917
|
88918
|
91728
|
91729
|
91730
|
91731
|
91732
|
91733
|
91734
|
91735
|
91736
|
91737
|
91738
|
91739
|
91740
| 93913 |
94097
|
94109
|
94110
|
94209
|
94616
|
94647