Bugzilla – Attachment 93959 Details for
Bug 14697
Extend and enhance "Claims returned" lost status
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14697: Don't unbless claims before rendering, it's done automatically
Bug-14697-Dont-unbless-claims-before-rendering-its.patch (text/plain), 2.11 KB, created by
Kyle M Hall (khall)
on 2019-10-10 14:44:55 UTC
(
hide
)
Description:
Bug 14697: Don't unbless claims before rendering, it's done automatically
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2019-10-10 14:44:55 UTC
Size:
2.11 KB
patch
obsolete
>From 0c63b78b483da526d0955d790c93a9cfcf0d39c8 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 10 Oct 2019 10:44:35 -0400 >Subject: [PATCH] Bug 14697: Don't unbless claims before rendering, it's done > automatically > >--- > Koha/REST/V1/ReturnClaims.pm | 33 +++------------------------------ > 1 file changed, 3 insertions(+), 30 deletions(-) > >diff --git a/Koha/REST/V1/ReturnClaims.pm b/Koha/REST/V1/ReturnClaims.pm >index ec5edc82bc..295f4e1444 100644 >--- a/Koha/REST/V1/ReturnClaims.pm >+++ b/Koha/REST/V1/ReturnClaims.pm >@@ -69,18 +69,7 @@ sub claim_returned { > } > ); > >- my $data = $claim->unblessed; >- >- my $c_dt = dt_from_string( $data->{created_on} ); >- my $u_dt = dt_from_string( $data->{updated_on} ); >- >- $data->{created_on_formatted} = output_pref( { dt => $c_dt } ); >- $data->{updated_on_formatted} = output_pref( { dt => $u_dt } ); >- >- $data->{created_on} = $c_dt->iso8601; >- $data->{updated_on} = $u_dt->iso8601; >- >- return $c->render( openapi => $data, status => 200 ); >+ return $c->render( openapi => $claim, status => 200 ); > } > > =head3 update_notes >@@ -165,21 +154,7 @@ sub resolve_claim { > ); > $claim->store(); > >- my $data = $claim->unblessed; >- >- my $c_dt = dt_from_string( $data->{created_on} ); >- my $u_dt = dt_from_string( $data->{updated_on} ); >- my $r_dt = dt_from_string( $data->{resolved_on} ); >- >- $data->{created_on_formatted} = output_pref( { dt => $c_dt } ); >- $data->{updated_on_formatted} = output_pref( { dt => $u_dt } ); >- $data->{resolved_on_formatted} = output_pref( { dt => $r_dt } ); >- >- $data->{created_on} = $c_dt->iso8601; >- $data->{updated_on} = $u_dt->iso8601; >- $data->{resolved_on} = $r_dt->iso8601; >- >- return $c->render( openapi => $data, status => 200 ); >+ return $c->render( openapi => $claim, status => 200 ); > } > > =head3 delete_claim >@@ -203,9 +178,7 @@ sub delete_claim { > > $claim->delete(); > >- my $data = $claim->unblessed; >- >- return $c->render( openapi => $data, status => 200 ); >+ return $c->render( openapi => $claim, status => 200 ); > } > > 1; >-- >2.21.0 (Apple Git-122)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14697
:
92407
|
92408
|
92409
|
92410
|
92962
|
92963
|
92964
|
92965
|
93005
|
93006
|
93007
|
93008
|
93012
|
93013
|
93014
|
93015
|
93017
|
93038
|
93039
|
93040
|
93041
|
93042
|
93061
|
93062
|
93063
|
93064
|
93065
|
93952
|
93953
|
93954
|
93955
|
93956
|
93957
|
93959
|
94842
|
94843
|
94844
|
94845
|
94846
|
94847
|
94848
|
94849
|
94850
|
94851
|
94852
|
94853
|
94854
|
94857
|
94877
|
94878