Bugzilla – Attachment 93981 Details for
Bug 23626
Add a system preference to limit the number of rows of data used when charting or exporting report results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23626: (follow-up) Fix JS when not viewing results
Bug-23626-follow-up-Fix-JS-when-not-viewing-result.patch (text/plain), 1.22 KB, created by
Nick Clemens (kidclamp)
on 2019-10-10 16:41:16 UTC
(
hide
)
Description:
Bug 23626: (follow-up) Fix JS when not viewing results
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-10-10 16:41:16 UTC
Size:
1.22 KB
patch
obsolete
>From 369065fa40bef492a319d0f89a942f7c35079b87 Mon Sep 17 00:00:00 2001 >From: Nick <nick@bywatersolutions.com> >Date: Thu, 10 Oct 2019 16:40:55 +0000 >Subject: [PATCH] Bug 23626: (follow-up) Fix JS when not viewing results > >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index cbb846a8cf..cac8ccbea4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -1161,7 +1161,7 @@ canned reports and writing custom SQL reports.</p> > $(document).ready(function(){ > > $("body").on('click',".fetch_chart_data",function(){ >- if( [% unlimited_total | $raw %] > 1000 ){ >+ if( [% unlimited_total || 0 | $raw %] > 1000 ){ > if( confirm("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you with to chart this report?") ){ > return true; > } else { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23626
:
92845
|
92904
|
92905
|
92908
|
92909
|
92910
|
92919
|
92920
|
92921
|
92992
|
92994
|
93126
|
93137
|
93204
|
93406
|
93589
|
93720
|
93723
|
93729
|
93914
|
93915
|
93916
| 93981