Attachment 94032 Details for Bug 23800 – bug23800 : fix regression

[patch] bug23800 : fix regression

0001-bug23800-fix-regression-in-batch-item-modification-t.patch (text/plain), 1.36 KB, created by Arthur Suzuki on 2019-10-11 21:50:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Arthur Suzuki

Created: 2019-10-11 21:50:15 UTC

Size: 1.36 KB

patch

obsolete

>From 1a44ddabdd0dada9050c0b42bba75c8b5a69e662 Mon Sep 17 00:00:00 2001
>From: Arthur Suzuki <arthur.suzuki@biblibre.com>
>Date: Fri, 11 Oct 2019 23:42:25 +0200
>Subject: [PATCH] bug23800 : fix regression in batch item modification tool
>
>Test plan :
>1/ scan several items in the Tools / Batch Item Modification
>2/ click continue
>3/ check that items were not displayed in the order they appeared in
>4/ apply patch
>5/ repeat step 1 and 2
>6/ verify that items now appear in the order they were scanned
>---
> tools/batchMod.pl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/tools/batchMod.pl b/tools/batchMod.pl
>index 2e6473784c..da71c3cf54 100755
>--- a/tools/batchMod.pl
>+++ b/tools/batchMod.pl
>@@ -282,7 +282,9 @@ if ($op eq "show"){
>             my @barcodelist = grep /\S/, ( split /[$split_chars]/, $list );
>             @barcodelist = uniq @barcodelist;
> 
>-            my $existing_items = Koha::Items->search({ barcode => \@barcodelist });
>+	    my $order = "field(" . join(",","barcode",@barcodelist) . ")";
>+            my $existing_items = Koha::Items->search({ barcode => \@barcodelist },
>+	                                             { order_by => \[$order] } );
>             @itemnumbers = $existing_items->get_column('itemnumber');
>             my @barcodes = $existing_items->get_column('barcode');
>             my %exists = map {lc($_)=>1} @barcodes;
>-- 
>2.20.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 23800: 93987 | 94032 | 94033 | 94034 | 94353 | 94354 | 95252 | 95659 | 96241 | 96242 | 96243