Attachment 94037 Details for Bug 17247 – Bug 17247: Check if patron is restricted in HoldItem and HoldTitle

[patch] Bug 17247: Check if patron is restricted in HoldItem and HoldTitle

Bug-17247-Check-if-patron-is-restricted-in-HoldIte.patch (text/plain), 1.55 KB, created by Katrin Fischer on 2019-10-12 11:24:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-10-12 11:24:21 UTC

Size: 1.55 KB

patch

obsolete

>From bfb3751bd184e742a0e6339a72615b49648ac079 Mon Sep 17 00:00:00 2001
>From: Arthur Suzuki <arthur.suzuki@biblibre.com>
>Date: Mon, 13 May 2019 11:29:50 +0200
>Subject: [PATCH] Bug 17247: Check if patron is restricted in HoldItem and
> HoldTitle
>
>Test plan:
>Make sure a restricted patron cannot hold a title or item through ILS-DI.
>Response from the WebService should be "PatronDebarred".
>
>Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> C4/ILSDI/Services.pm | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm
>index 049ddcf600..fbc77e3398 100644
>--- a/C4/ILSDI/Services.pm
>+++ b/C4/ILSDI/Services.pm
>@@ -688,6 +688,9 @@ sub HoldTitle {
>     my $patron = Koha::Patrons->find( $borrowernumber );
>     return { code => 'PatronNotFound' } unless $patron;
> 
>+    # If borrower is debarred return an error code
>+    return { code => 'PatronDebarred' } if $patron->is_debarred;
>+
>     # Get the biblio record, or return an error code
>     my $biblionumber = $cgi->param('bib_id');
>     my $biblio = Koha::Biblios->find( $biblionumber );
>@@ -773,6 +776,9 @@ sub HoldItem {
>     my $patron = Koha::Patrons->find( $borrowernumber );
>     return { code => 'PatronNotFound' } unless $patron;
> 
>+    # If borrower is debarred return an error code
>+    return { code => 'PatronDebarred' } if $patron->is_debarred;
>+
>     # Get the biblio or return an error code
>     my $biblionumber = $cgi->param('bib_id');
>     my $biblio = Koha::Biblios->find( $biblionumber );
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 17247: 55174 | 70684 | 72963 | 75261 | 75262 | 75270 | 89652 | 89653 | 93549 | 94037 | 94038