Attachment 94085 Details for Bug 23049 – Bug 23049: Capitalise type passed to add_debit for lost_item

[patch] Bug 23049: Capitalise type passed to add_debit for lost_item

Bug-23049-Capitalise-type-passed-to-adddebit-for-l.patch (text/plain), 3.13 KB, created by Martin Renvoize (ashimema) on 2019-10-14 10:35:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-10-14 10:35:06 UTC

Size: 3.13 KB

patch

obsolete

>From d9a9cdb09d7c2f423b1a851f48f4b2edaef6f08d Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 10 Oct 2019 16:41:22 +0100
>Subject: [PATCH] Bug 23049: Capitalise type passed to add_debit for lost_item
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>---
> C4/Accounts.pm                                        | 2 +-
> Koha/Account.pm                                       | 6 +++---
> t/db_dependent/Circulation/NoIssuesChargeGuarantees.t | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/C4/Accounts.pm b/C4/Accounts.pm
>index 3f06595d74..53fd8b77fa 100644
>--- a/C4/Accounts.pm
>+++ b/C4/Accounts.pm
>@@ -124,7 +124,7 @@ sub chargelostitem {
>                     user_id     => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef,
>                     interface   => C4::Context->interface,
>                     library_id  => C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef,
>-                    type        => 'lost_item',
>+                    type        => 'LOST',
>                     item_id     => $itemnumber,
>                     issue_id    => $issue_id,
>                 }
>diff --git a/Koha/Account.pm b/Koha/Account.pm
>index 2c8c4a1e7d..fbb2731c95 100644
>--- a/Koha/Account.pm
>+++ b/Koha/Account.pm
>@@ -447,7 +447,7 @@ $debit_type can be any of:
>   - ACCOUNT
>   - ACCOUNT_RENEW
>   - RESERVE_EXPIRED
>-  - lost_item
>+  - LOST
>   - sundry
>   - new_card
>   - overdue
>@@ -713,7 +713,7 @@ our $offset_type = {
>     'ACCOUNT_RENEW'    => 'Account Fee',
>     'RESERVE'          => 'Reserve Fee',
>     'PROCESSING'       => 'Processing Fee',
>-    'lost_item'        => 'Lost Item',
>+    'LOST'             => 'Lost Item',
>     'RENT'             => 'Rental Fee',
>     'RENT_DAILY'       => 'Rental Fee',
>     'RENT_RENEW'       => 'Rental Fee',
>@@ -743,7 +743,7 @@ our $account_type_debit = {
>     'ACCOUNT'          => 'ACCOUNT',
>     'ACCOUNT_RENEW'    => 'ACCOUNT_RENEW',
>     'RESERVE_EXPIRED'  => 'RESERVE_EXPIRED',
>-    'lost_item'        => 'LOST',
>+    'LOST_ITEM'        => 'LOST',
>     'sundry'           => 'M',
>     'new_card'         => 'N',
>     'overdue'          => 'OVERDUE',
>diff --git a/t/db_dependent/Circulation/NoIssuesChargeGuarantees.t b/t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
>index ed15c4fd18..7f496aed83 100644
>--- a/t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
>+++ b/t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
>@@ -81,7 +81,7 @@ my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item-
> is( $issuingimpossible->{DEBT_GUARANTEES}, undef, "Patron can check out item" );
> 
> my $account = Koha::Account->new( { patron_id => $guarantee->id } );
>-$account->add_debit({ amount => 10.00, type => 'lost_item', interface => 'test' });
>+$account->add_debit({ amount => 10.00, type => 'LOST', interface => 'test' });
> ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->{barcode} );
> is( $issuingimpossible->{DEBT_GUARANTEES} + 0, '10.00' + 0, "Patron cannot check out item due to debt for guarantee" );
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23049: 93513 | 93514 | 93515 | 93516 | 93518 | 93519 | 93520 | 93521 | 93522 | 93523 | 93529 | 93557 | 93564 | 93565 | 93567 | 93568 | 93569 | 93570 | 93571 | 93572 | 93573 | 93574 | 93575 | 93576 | 93577 | 93578 | 93579 | 93960 | 93961 | 93962 | 93963 | 93964 | 93965 | 93966 | 93967 | 93968 | 93969 | 93970 | 93972 | 93973 | 93974 | 93975 | 93976 | 93977 | 93978 | 93979 | 93989 | 93990 | 93991 | 93992 | 93993 | 93994 | 93995 | 93996 | 93997 | 93998 | 93999 | 94000 | 94001 | 94002 | 94003 | 94004 | 94005 | 94006 | 94007 | 94008 | 94073 | 94074 | 94075 | 94076 | 94077 | 94078 | 94079 | 94080 | 94081 | 94082 | 94083 | 94084 | 94085 | 94086 | 94087 | 94088 | 94089 | 94090 | 94091 | 94092 | 94093 | 94111 | 94112 | 94113 | 94114 | 94115 | 94116 | 94117 | 94118 | 94119 | 94120 | 94121 | 94122 | 94123 | 94124 | 94125 | 94126 | 94127 | 94128 | 94129 | 94130 | 94131 | 94132 | 94133 | 94134 | 94135 | 94136 | 94137 | 94138 | 94139 | 94140 | 94141 | 94142 | 94143 | 94144 | 94145 | 94146 | 94147 | 94148 | 94149 | 94150 | 94151 | 94152 | 94165 | 94307 | 94308 | 94309 | 94310 | 94311 | 94312 | 94313 | 94314 | 94315 | 94316 | 94317 | 94318 | 94319 | 94320 | 94321 | 94323 | 94324 | 94325 | 94326 | 94327 | 94328 | 94329 | 94331 | 94332 | 94333 | 94334 | 94335 | 94336 | 94337 | 94338 | 94339 | 94340 | 94341 | 94342 | 94343 | 94344 | 94345 | 94346 | 94347 | 94348 | 94349 | 94350 | 94351 | 94352 | 94648