Bugzilla – Attachment 94159 Details for
Bug 23805
Add a dedicated credit_types table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23805: Update 'lost_item_return' to 'LOST_RETURN' for consistency
Bug-23805-Update-lostitemreturn-to-LOSTRETURN-for-.patch (text/plain), 2.56 KB, created by
Martin Renvoize (ashimema)
on 2019-10-15 08:47:32 UTC
(
hide
)
Description:
Bug 23805: Update 'lost_item_return' to 'LOST_RETURN' for consistency
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-10-15 08:47:32 UTC
Size:
2.56 KB
patch
obsolete
>From 34c560491239129a1cb4bf99bcb758e84d63493b Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 14 Oct 2019 16:36:34 +0100 >Subject: [PATCH] Bug 23805: Update 'lost_item_return' to 'LOST_RETURN' for > consistency > >--- > C4/Circulation.pm | 2 +- > Koha/Account.pm | 6 +++--- > api/v1/swagger/definitions/patron_account_credit.json | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 5ccf498739..f73821ec59 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2454,7 +2454,7 @@ sub _FixAccountForLostAndReturned { > $credit = $account->add_credit( > { amount => $credit_total, > description => 'Item Returned ' . $item_id, >- type => 'lost_item_return', >+ type => 'LOST_RETURN', > interface => C4::Context->interface, > library_id => $branchcode > } >diff --git a/Koha/Account.pm b/Koha/Account.pm >index baed3571df..39321ae749 100644 >--- a/Koha/Account.pm >+++ b/Koha/Account.pm >@@ -325,7 +325,7 @@ $credit_type can be any of: > - 'CREDIT' > - 'payment' > - 'forgiven' >- - 'lost_item_return' >+ - 'LOST_RETURN' > - 'writeoff' > > =cut >@@ -718,7 +718,7 @@ sub reconcile_balance { > our $offset_type = { > 'CREDIT' => 'Manual Credit', > 'FORGIVEN' => 'Writeoff', >- 'lost_item_return' => 'Lost Item', >+ 'LOST_RETURN' => 'Lost Item', > 'payment' => 'Payment', > 'writeoff' => 'Writeoff', > 'ACCOUNT' => 'Account Fee', >@@ -741,7 +741,7 @@ our $offset_type = { > our $account_type_credit = { > 'CREDIT' => 'CREDIT', > 'FORGIVEN' => 'FORGIVEN', >- 'lost_item_return' => 'LOST_RETURN', >+ 'LOST_RETURN' => 'LOST_RETURN', > 'payment' => 'Pay', > 'writeoff' => 'W' > }; >diff --git a/api/v1/swagger/definitions/patron_account_credit.json b/api/v1/swagger/definitions/patron_account_credit.json >index 6b0889b168..9f00f26eda 100644 >--- a/api/v1/swagger/definitions/patron_account_credit.json >+++ b/api/v1/swagger/definitions/patron_account_credit.json >@@ -3,7 +3,7 @@ > "properties": { > "credit_type": { > "type": "string", >- "description": "Type of credit ('CREDIT', 'FORGIVEN', 'lost_item_return', 'payment', 'writeoff' )" >+ "description": "Type of credit ('CREDIT', 'FORGIVEN', 'LOST_RETURN', 'payment', 'writeoff' )" > }, > "amount": { > "type": "number", >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23805
:
94153
|
94154
|
94155
|
94156
|
94157
|
94158
|
94159
|
94160
|
94161
|
94162
|
94163
|
94164
|
94166
|
94167
|
94168
|
94169
|
94170
|
94171
|
94172
|
94173
|
94174
|
94175
|
94176
|
94177
|
94178
|
94801
|
94815
|
94832
|
94895