Bugzilla – Attachment 94180 Details for
Bug 18936
Move issuingrules into circulation_rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18936: (followup) Fix upgrade step
Bug-18936-followup-Fix-upgrade-step.patch (text/plain), 2.79 KB, created by
Jonathan Druart
on 2019-10-15 12:32:57 UTC
(
hide
)
Description:
Bug 18936: (followup) Fix upgrade step
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-10-15 12:32:57 UTC
Size:
2.79 KB
patch
obsolete
>From bd407acd7c64ba85bbfed1ce5de6c4edf707f0b2 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 17 Jul 2017 16:04:51 -0300 >Subject: [PATCH] Bug 18936: (followup) Fix upgrade step > >--- > installer/data/mysql/atomicupdate/bug_18936.perl | 72 ++++++++++++------------ > 1 file changed, 36 insertions(+), 36 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_18936.perl b/installer/data/mysql/atomicupdate/bug_18936.perl >index 61b5fb9c6a..b420fce6f3 100644 >--- a/installer/data/mysql/atomicupdate/bug_18936.perl >+++ b/installer/data/mysql/atomicupdate/bug_18936.perl >@@ -1,45 +1,45 @@ > $DBversion = 'XXX'; # will be replaced by the RM > if( CheckVersion( $DBversion ) ) { >- my @columns = qw( >- restrictedtype >- rentaldiscount >- fine >- finedays >- maxsuspensiondays >- firstremind >- chargeperiod >- chargeperiod_charge_at >- accountsent >- issuelength >- lengthunit >- hardduedate >- hardduedatecompare >- renewalsallowed >- renewalperiod >- norenewalbefore >- auto_renew >- no_auto_renewal_after >- no_auto_renewal_after_hard_limit >- reservesallowed >- holds_per_record >- overduefinescap >- cap_fine_to_replacement_price >- onshelfholds >- opacitemholds >- article_requests >- ); >+ my @columns = qw( >+ restrictedtype >+ rentaldiscount >+ fine >+ finedays >+ maxsuspensiondays >+ firstremind >+ chargeperiod >+ chargeperiod_charge_at >+ accountsent >+ issuelength >+ lengthunit >+ hardduedate >+ hardduedatecompare >+ renewalsallowed >+ renewalperiod >+ norenewalbefore >+ auto_renew >+ no_auto_renewal_after >+ no_auto_renewal_after_hard_limit >+ reservesallowed >+ holds_per_record >+ overduefinescap >+ cap_fine_to_replacement_price >+ onshelfholds >+ opacitemholds >+ article_requests >+ ); > > if ( column_exists( 'issuingrules', 'categorycode' ) ) { >- foreach my $column ( @columns ) { >- $dbh->do(" >- INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) >- SELECT categorycode, branchcode, itemtype, 'column', $column >- FROM issuingrules >- "); >- } >+ foreach my $column ( @columns ) { >+ $dbh->do(" >+ INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) >+ SELECT categorycode, branchcode, itemtype, \'$column\', $column >+ FROM issuingrules >+ "); >+ } > $dbh->do("DROP TABLE issuingrules"); > } > > SetVersion( $DBversion ); >- print "Upgrade to $DBversion done (Bug 18930 - Move lost item refund rules to circulation_rules table)\n"; >+ print "Upgrade to $DBversion done (Bug 18936: Convert issuingrules fields to circulation_rules)\n"; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18936
:
65247
|
65248
|
65249
|
67629
|
67758
|
68236
|
71034
|
71035
|
71036
|
71037
|
71038
|
71039
|
71040
|
71041
|
72230
|
72231
|
72232
|
72233
|
72234
|
72235
|
72236
|
72237
|
72238
|
91953
|
91954
|
91955
|
91956
|
91957
|
91958
|
91959
|
91960
|
91961
|
91962
|
91963
|
91964
|
91965
|
91966
|
91967
|
91968
|
91969
|
91970
|
91971
|
91972
|
91973
|
91974
|
91975
|
94179
|
94180
|
94181
|
94182
|
94183
|
94184
|
94185
|
94186
|
94187
|
94188
|
94189
|
94190
|
94191
|
94192
|
94193
|
94194
|
94195
|
94196
|
94197
|
94198
|
94199
|
94200
|
98299
|
98300
|
98301
|
98302
|
98303
|
98304
|
98305
|
98306
|
98307
|
98308
|
98309
|
98310
|
98311
|
98312
|
98313
|
98314
|
98315
|
98316
|
98317
|
98318
|
98319
|
98320
|
98321
|
98322
|
98323
|
98324
|
98325
|
98326
|
98327
|
98328
|
98329
|
98330
|
98331
|
98332
|
98333
|
98334
|
98335
|
98336
|
98337
|
98338
|
98339
|
98340
|
98341
|
98342
|
98343
|
98344
|
98345
|
98346
|
98347
|
98407
|
98408