Bugzilla – Attachment 94214 Details for
Bug 23551
Problem with renewal period when using the renewal tab
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23551: Fix AddRenewal call in circ/renew.pl
Bug-23551-Fix-AddRenewal-call-in-circrenewpl.patch (text/plain), 1.67 KB, created by
Jonathan Druart
on 2019-10-15 13:43:30 UTC
(
hide
)
Description:
Bug 23551: Fix AddRenewal call in circ/renew.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-10-15 13:43:30 UTC
Size:
1.67 KB
patch
obsolete
>From 69f0cbfcd63a76eeee77318610d7fc1d5644d2d2 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 4 Oct 2019 14:06:27 +0100 >Subject: [PATCH] Bug 23551: Fix AddRenewal call in circ/renew.pl > >Without the patch, renewing from the renewal tab/page >led to wrong renewal/due dates. > >To test: >- Check an item out to your patron account >- Renew it from the patron account >- Note the due date >- Return the item >- Check the item out again >- Renew it using the renewal tab >- Verify a different due date was calculated >- Apply patch >- Repeat test - due dates now should be the same > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > circ/renew.pl | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/circ/renew.pl b/circ/renew.pl >index a431a2c4a3..df1e043bdb 100755 >--- a/circ/renew.pl >+++ b/circ/renew.pl >@@ -95,7 +95,11 @@ if ($barcode) { > } > if ($can_renew) { > my $branchcode = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; >- my $date_due = AddRenewal( undef, $item->itemnumber(), $branchcode, dt_from_string( scalar $cgi->param('renewonholdduedate')) ); >+ my $date_due; >+ if ( $cgi->param('renewonholdduedate') ) { >+ $date_due = dt_from_string( scalar $cgi->param('renewonholdduedate')); >+ } >+ $date_due = AddRenewal( undef, $item->itemnumber(), $branchcode, $date_due ); > $template->param( date_due => $date_due ); > } > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23551
:
93746
|
94105
| 94214