Bugzilla – Attachment 94219 Details for
Bug 23129
Items holdingbranch should be set to the originating library when generating a transfer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23129: (RM follow-up) Fix failing test
Bug-23129-RM-follow-up-Fix-failing-test.patch (text/plain), 1.57 KB, created by
Martin Renvoize (ashimema)
on 2019-10-15 15:51:11 UTC
(
hide
)
Description:
Bug 23129: (RM follow-up) Fix failing test
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-10-15 15:51:11 UTC
Size:
1.57 KB
patch
obsolete
>From 480434bbf4a32750c5e47a3600b6a386d9732296 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 15 Oct 2019 16:49:07 +0100 >Subject: [PATCH] Bug 23129: (RM follow-up) Fix failing test > >This patch corrects a test that was testing for the oposite behaviour to >that introduced in this patchset. We have agreed on the bug that the >new behaviour is desired and so I have updated the test to follow. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Circulation.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index b7dca93851..f0086a0e73 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -2645,7 +2645,7 @@ subtest 'Cancel transfers on lost items' => sub { > my ($datesent,$frombranch,$tobranch) = GetTransfers($item->itemnumber); > is( $tobranch, $library_2->{branchcode}, 'The transfer record exists in the branchtransfers table'); > my $itemcheck = Koha::Items->find($item->itemnumber); >- is( $itemcheck->holdingbranch, $library_2->{branchcode}, 'Items holding branch is the transfers destination branch before it is marked as lost' ); >+ is( $itemcheck->holdingbranch, $library_1->{branchcode}, 'Items holding branch is the transfers origin branch before it is marked as lost' ); > > #Simulate item being marked as lost and confirm the transfer is deleted and the items holding branch is the transfers source branch > ModItem( { itemlost => 1 }, $item->biblionumber, $item->itemnumber ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23129
:
90619
|
90620
|
91488
|
91489
|
93043
|
93045
|
93227
|
93228
| 94219