Attachment 94273 Details for Bug 23806 – Bug 23806: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button

[patch] Bug 23806: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button

Bug-23806-FinePaymentAutoPopup-does-not-trigger-po.patch (text/plain), 1.18 KB, created by Kyle M Hall (khall) on 2019-10-16 11:49:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2019-10-16 11:49:21 UTC

Size: 1.18 KB

patch

obsolete

>From 37ffbebb0297569d713532db447919d261bee4f9 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 11 Oct 2019 09:07:14 -0700
>Subject: [PATCH] Bug 23806: FinePaymentAutoPopup does not trigger pop-up for
> writeoff by "Write off" button
>
>Test Plan:
>1) Enable reciept popups for payments and writeoffs
>2) Test the "Write off" button, no popup
>3) Apply this patch
>4) Restart all the things!
>5) Test again, you should get the popup!
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
>---
> members/pay.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/members/pay.pl b/members/pay.pl
>index ee2d5f23ff..886639d6fa 100755
>--- a/members/pay.pl
>+++ b/members/pay.pl
>@@ -112,7 +112,7 @@ elsif ( $input->param('confirm_writeoff') ) {
>               . "&error_over=1" );
> 
>     } else {
>-        Koha::Account->new( { patron_id => $borrowernumber } )->pay(
>+        $payment_id = Koha::Account->new( { patron_id => $borrowernumber } )->pay(
>             {
>                 amount     => $amount,
>                 lines      => [ scalar Koha::Account::Lines->find($accountlines_id) ],
>-- 
>2.21.0 (Apple Git-122)

Actions: View | Diff | Splinter Review

Attachments on bug 23806: 94025 | 94273 | 95153