Attachment 94309 Details for Bug 23049 – Bug 23049: Account types configuration - Admin page

[patch] Bug 23049: Account types configuration - Admin page

Bug-23049-Account-types-configuration---Admin-page.patch (text/plain), 27.30 KB, created by Martin Renvoize (ashimema) on 2019-10-16 15:30:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-10-16 15:30:19 UTC

Size: 27.30 KB

patch

obsolete

>From b07f5277cf65beb204e0acdf52044f62eb229caa Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 10 Oct 2019 17:14:23 +0100
>Subject: [PATCH] Bug 23049: Account types configuration - Admin page
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Test plan:
>1) Go to admin home, note there is new Debit types page in Accounting
>   section
>2) Go to any other admin page and confirm there is link to Debit types
>   in the admin menu as well
>3) Go to Debit types page
>4) You should see a datatable listing existing debit types, ensure they
>   are working as expected.
>5) Try to create, edit and delete some debit types. Note: Some debit
>   types cannot be deleted as they are needed for koha functionality.
>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>---
> Koha/Account/DebitType.pm                     |  16 +-
> Koha/Account/DebitTypes.pm                    |   3 +-
> admin/debit_types.pl                          | 146 +++++++++++
> .../prog/en/includes/admin-menu.inc           |   7 +-
> .../prog/en/modules/admin/admin-home.tt       |  66 ++---
> .../prog/en/modules/admin/debit_types.tt      | 234 ++++++++++++++++++
> 6 files changed, 437 insertions(+), 35 deletions(-)
> create mode 100755 admin/debit_types.pl
> create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt
>
>diff --git a/Koha/Account/DebitType.pm b/Koha/Account/DebitType.pm
>index 59bb5c1e5e..6324ec57cb 100644
>--- a/Koha/Account/DebitType.pm
>+++ b/Koha/Account/DebitType.pm
>@@ -23,7 +23,7 @@ use List::Util qw/any/;
> use Koha::Database;
> use Koha::Exceptions;
> 
>-use base qw(Koha::Object);
>+use base qw(Koha::Object Koha::Object::Limit::Library);
> 
> =head1 NAME
> 
>@@ -49,6 +49,20 @@ sub delete {
>     return $self->SUPER::delete;
> }
> 
>+=head3 _library_limits
>+
>+Configurable library limits
>+
>+=cut
>+
>+sub _library_limits {
>+    return {
>+        class   => "AccountDebitTypesBranch",
>+        id      => "debit_type_code",
>+        library => "branchcode",
>+    };
>+}
>+
> =head3 type
> 
> =cut
>diff --git a/Koha/Account/DebitTypes.pm b/Koha/Account/DebitTypes.pm
>index 2e6eb2c9b6..f19bce0382 100644
>--- a/Koha/Account/DebitTypes.pm
>+++ b/Koha/Account/DebitTypes.pm
>@@ -21,8 +21,9 @@ use Modern::Perl;
> use List::Util qw/any/;
> 
> use Koha::Database;
>+use Koha::Account::DebitType;
> 
>-use base qw(Koha::Objects);
>+use base qw(Koha::Objects Koha::Objects::Limit::Library);
> 
> =head1 NAME
> 
>diff --git a/admin/debit_types.pl b/admin/debit_types.pl
>new file mode 100755
>index 0000000000..a8336e69bb
>--- /dev/null
>+++ b/admin/debit_types.pl
>@@ -0,0 +1,146 @@
>+#! /usr/bin/perl
>+
>+# Copyright 2016 Koha Development Team
>+#
>+# This file is part of Koha.
>+#
>+# Koha is free software; you can redistribute it and/or modify it
>+# under the terms of the GNU General Public License as published by
>+# the Free Software Foundation; either version 3 of the License, or
>+# (at your option) any later version.
>+#
>+# Koha is distributed in the hope that it will be useful, but
>+# WITHOUT ANY WARRANTY; without even the implied warranty of
>+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+# GNU General Public License for more details.
>+#
>+# You should have received a copy of the GNU General Public License
>+# along with Koha; if not, see <http://www.gnu.org/licenses>.
>+
>+use Modern::Perl;
>+use CGI qw ( -utf8 );
>+use C4::Context;
>+use C4::Auth;
>+use C4::Output;
>+
>+use Koha::Account::DebitTypes;
>+
>+my $input = new CGI;
>+my $code  = $input->param('code');
>+my $op    = $input->param('op') || 'list';
>+my $type  = $input->param('type');
>+my @messages;
>+
>+my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>+    {
>+        template_name   => "admin/debit_types.tt",
>+        query           => $input,
>+        type            => "intranet",
>+        authnotrequired => 0,
>+        flagsrequired   => { parameters => 'parameters_remaining_permissions' },
>+        debug           => 1,
>+    }
>+);
>+
>+if ( $op eq 'add_form' ) {
>+    my $debit_type;
>+    if ($code) {
>+        $debit_type = Koha::Account::DebitTypes->find($code);
>+    }
>+
>+    my $selected_branches =
>+      $debit_type ? $debit_type->get_library_limits : undef;
>+    my $branches =
>+      Koha::Libraries->search( {}, { order_by => ['branchname'] } )->unblessed;
>+    my @branches_loop;
>+    foreach my $branch (@$branches) {
>+        my $selected =
>+          ( $selected_branches
>+              && grep { $_->branchcode eq $branch->{branchcode} }
>+              @{ $selected_branches->as_list } ) ? 1 : 0;
>+        push @branches_loop,
>+          {
>+            branchcode => $branch->{branchcode},
>+            branchname => $branch->{branchname},
>+            selected   => $selected,
>+          };
>+    }
>+
>+    $template->param(
>+        debit_type    => $debit_type,
>+        type          => $type,
>+        branches_loop => \@branches_loop
>+    );
>+}
>+elsif ( $op eq 'add_validate' ) {
>+    my $description = $input->param('description');
>+    my $can_be_added_manually = $input->param('can_be_added_manually') || 0;
>+    my $default_amount;
>+    if ( $type eq "debit" ) {
>+        $default_amount = $input->param('default_amount') || undef;
>+    }
>+    my @branches = grep { $_ ne q{} } $input->multi_param('branches');
>+
>+    my $debit_type;
>+    $debit_type = Koha::Account::DebitTypes->find($code);
>+    if ( not defined $debit_type ) {
>+        $debit_type = Koha::Account::DebitType->new( { code => $code } );
>+    }
>+    $debit_type->description($description);
>+    $debit_type->can_be_added_manually($can_be_added_manually);
>+    $debit_type->default_amount($default_amount);
>+
>+    eval {
>+        $debit_type->store;
>+        $debit_type->replace_library_limits( \@branches );
>+    };
>+    if ($@) {
>+        push @messages, { type => 'error', code => 'error_on_saving' };
>+    }
>+    else {
>+        push @messages, { type => 'message', code => 'success_on_saving' };
>+    }
>+    $op = 'list';
>+}
>+elsif ( $op eq 'delete_confirm' ) {
>+    my $debit_type;
>+    if ( $type eq "debit" ) {
>+        $debit_type = Koha::Account::DebitTypes->find($code);
>+    }
>+    else {
>+        $debit_type = Koha::Account::CreditTypes->find($code);
>+    }
>+    $template->param( debit_type => $debit_type );
>+    $template->param( type       => $type );
>+}
>+elsif ( $op eq 'delete_confirmed' ) {
>+    my $debit_type;
>+    if ( $type eq "debit" ) {
>+        $debit_type = Koha::Account::DebitTypes->find($code);
>+    }
>+    else {
>+        $debit_type = Koha::Account::CreditTypes->find($code);
>+    }
>+    my $deleted = eval { $debit_type->delete; };
>+
>+    if ( $@ or not $deleted ) {
>+        push @messages, { type => 'error', code => 'error_on_delete' };
>+    }
>+    else {
>+        push @messages, { type => 'message', code => 'success_on_delete' };
>+    }
>+    $op = 'list';
>+}
>+
>+if ( $op eq 'list' ) {
>+    my $debit_types = Koha::Account::DebitTypes->search();
>+    $template->param( debit_types => $debit_types );
>+}
>+
>+$template->param(
>+    code     => $code,
>+    messages => \@messages,
>+    op       => $op,
>+);
>+
>+output_html_with_http_headers $input, $cookie, $template->output;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc
>index 1578c2db7f..f24f3e83fc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc
>@@ -51,10 +51,13 @@
>         </ul>
>     [% END %]
> 
>-    [% IF ( Koha.Preference('UseCashRegisters') && CAN_user_cash_management_manage_cash_registers ) %]
>+    [% IF ( CAN_user_parameters_manage_accounts || ( Koha.Preference('UseCashRegisters') && CAN_user_cash_management_manage_cash_registers ) ) %]
>         <h5>Accounting</h5>
>         <ul>
>-            [% IF ( CAN_user_cash_management_manage_cash_registers ) %]
>+            [% IF ( CAN_user_parameters_manage_accounts ) %]
>+                <li><a href="/cgi-bin/koha/admin/debit_types.pl">Debit types</a></li>
>+            [% END %]
>+            [% IF ( Koha.Preference('UseCashRegisters') && CAN_user_cash_management_manage_cash_registers ) %]
>                 <li><a href="/cgi-bin/koha/admin/cash_registers.pl">Cash registers</a></li>
>             [% END %]
>         </ul>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
>index 4095e516e9..5059cbfa34 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
>@@ -69,42 +69,46 @@
>             [% IF ( CAN_user_parameters_manage_patron_categories || CAN_user_parameters_manage_circ_rules || CAN_user_parameters_manage_patron_attributes || CAN_user_parameters_manage_transfers || CAN_user_parameters_manage_item_circ_alerts || CAN_user_parameters_manage_cities ) %]
>                 <h3>Patrons and circulation</h3>
>                 <dl>
>-                    [% IF ( CAN_user_parameters_manage_patron_categories ) %]
>-                        <dt><a href="/cgi-bin/koha/admin/categories.pl">Patron categories</a></dt>
>-                        <dd>Define patron categories.</dd>
>-                    [% END %]
>-                    [% IF ( CAN_user_parameters_manage_circ_rules ) %]
>-                        <dt><a href="/cgi-bin/koha/admin/smart-rules.pl">Circulation and fines rules</a></dt>
>-                        <dd>Define circulation and fines rules for combinations of libraries, patron categories, and item types</dd>
>-                    [% END %]
>-                    [% IF ( CAN_user_parameters_manage_patron_attributes ) %]
>-                        <dt><a href="/cgi-bin/koha/admin/patron-attr-types.pl">Patron attribute types</a></dt>
>-                        <dd>Define extended attributes (identifiers and statistical categories) for patron records</dd>
>-                    [% END %]
>-                    [% IF ( CAN_user_parameters_manage_transfers ) %]
>-                        <dt><a href="/cgi-bin/koha/admin/branch_transfer_limits.pl">Library transfer limits</a></dt>
>-                        <dd>Limit the ability to transfer items between libraries based on the library sending, the library receiving, and the item type involved. These rules only go into effect if the preference UseBranchTransferLimits is set to ON.</dd>
>-                        <dt><a href="/cgi-bin/koha/admin/transport-cost-matrix.pl">Transport cost matrix</a></dt>
>-                        <dd>Define transport costs between branches</dd>
>-                    [% END %]
>-                    [% IF ( CAN_user_parameters_manage_item_circ_alerts ) %]
>-                        <dt><a href="/cgi-bin/koha/admin/item_circulation_alerts.pl">Item circulation alerts</a></dt>
>-                        <dd>Define rules for check-in and checkout notifications for combinations of libraries, patron categories, and item types</dd>
>-                    [% END %]
>-                    [% IF ( CAN_user_parameters_manage_cities ) %]
>-                        <dt><a href="/cgi-bin/koha/admin/cities.pl">Cities and towns</a></dt>
>-                        <dd>Define cities and towns that your patrons live in.</dd>
>-                    [% END %]
>+                [% IF ( CAN_user_parameters_manage_patron_categories ) %]
>+                    <dt><a href="/cgi-bin/koha/admin/categories.pl">Patron categories</a></dt>
>+                    <dd>Define patron categories.</dd>
>+                [% END %]
>+                [% IF CAN_user_parameters_manage_circ_rules %]
>+                    <dt><a href="/cgi-bin/koha/admin/smart-rules.pl">Circulation and fines rules</a></dt>
>+                    <dd>Define circulation and fines rules for combinations of libraries, patron categories, and item types</dd>
>+                [% END %]
>+                [% IF ( CAN_user_parameters_manage_patron_attributes ) %]
>+                    <dt><a href="/cgi-bin/koha/admin/patron-attr-types.pl">Patron attribute types</a></dt>
>+                    <dd>Define extended attributes (identifiers and statistical categories) for patron records</dd>
>+                [% END %]
>+                [% IF ( CAN_user_parameters_manage_transfers ) %]
>+                    <dt><a href="/cgi-bin/koha/admin/branch_transfer_limits.pl">Library transfer limits</a></dt>
>+                    <dd>Limit the ability to transfer items between libraries based on the library sending, the library receiving, and the item type involved. These rules only go into effect if the preference UseBranchTransferLimits is set to ON.</dd>
>+                    <dt><a href="/cgi-bin/koha/admin/transport-cost-matrix.pl">Transport cost matrix</a></dt>
>+                    <dd>Define transport costs between branches</dd>
>+                [% END %]
>+                [% IF ( CAN_user_parameters_manage_item_circ_alerts ) %]
>+                    <dt><a href="/cgi-bin/koha/admin/item_circulation_alerts.pl">Item circulation alerts</a></dt>
>+                    <dd>Define rules for check-in and checkout notifications for combinations of libraries, patron categories, and item types</dd>
>+                [% END %]
>+                [% IF ( CAN_user_parameters_manage_cities ) %]
>+                    <dt><a href="/cgi-bin/koha/admin/cities.pl">Cities and towns</a></dt>
>+                    <dd>Define cities and towns that your patrons live in.</dd>
>+                [% END %]
>                 </dl>
>             [% END %]
> 
>-            [% IF ( Koha.Preference('UseCashRegisters') && CAN_user_cash_management_manage_cash_registers ) %]
>+            [% IF ( CAN_user_parameters_manage_accounts || ( Koha.Preference('UseCashRegisters') && CAN_user_cash_management_manage_cash_registers ) ) %]
>                 <h3>Accounting</h3>
>                 <dl>
>-                    [% IF ( CAN_user_cash_management_manage_cash_registers ) %]
>-                        <dt><a href="/cgi-bin/koha/admin/cash_registers.pl">Cash registers</a></dt>
>-                        <dd>Define cash registers</dd>
>-                    [% END %]
>+                [% IF ( CAN_user_parameters_manage_accounts ) %]
>+                    <dt><a href="/cgi-bin/koha/admin/debit_types.pl">Debit types</a></dt>
>+                    <dd>Define debit types.</dd>
>+                [% END %]
>+                [% IF ( Koha.Preference('UseCashRegisters') && CAN_user_cash_management_manage_cash_registers ) %]
>+                    <dt><a href="/cgi-bin/koha/admin/cash_registers.pl">Cash registers</a></dt>
>+                    <dd>Define cash registers</dd>
>+                [% END %]
>                 </dl>
>             [% END %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt
>new file mode 100644
>index 0000000000..986e57d5c7
>--- /dev/null
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt
>@@ -0,0 +1,234 @@
>+[% USE raw %]
>+[% USE Asset %]
>+[% USE Branches %]
>+[% USE Price %]
>+[% SET footerjs = 1 %]
>+[% INCLUDE 'doc-head-open.inc' %]
>+<title>Koha &rsaquo; Administration &rsaquo;
>+    [% IF op =='add_form' %]
>+       Debit types &rsaquo;
>+       [% IF debit_type.code %]
>+           Modify debit type
>+       [% ELSE %]
>+           New debit type
>+       [% END %]
>+    [% ELSE %]
>+       [% IF op == 'delete_confirm' %]
>+           Debit types &rsaquo; Confirm deletion of debit type
>+       [% ELSE %]
>+           Debit types
>+       [% END %]
>+    [% END %]
>+</title>
>+[% INCLUDE 'doc-head-close.inc' %]
>+</head>
>+
>+<body id="admin_debit_types" class="admin">
>+[% INCLUDE 'header.inc' %]
>+[% INCLUDE 'prefs-admin-search.inc' %]
>+
>+<div id="breadcrumbs">
>+    <a href="/cgi-bin/koha/mainpage.pl">Home</a>
>+&rsaquo; <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a>
>+&rsaquo; <a href="/cgi-bin/koha/admin/debit_types.pl">Debit types</a>
>+[% IF op == 'add_form' %]
>+&rsaquo; [% IF debit_type.code %]Modify[% ELSE %]New[% END %] debit type
>+[% ELSIF op == 'delete_confirm' %]
>+&rsaquo; Confirm deletion of debit type
>+[% END %]
>+</div>
>+
>+<div class="main container-fluid">
>+    <div class="row">
>+        <div class="col-sm-10 col-sm-push-2">
>+            <main>
>+
>+                [% FOREACH m IN messages %]
>+                <div class="dialog [% m.type | html %]">
>+                    [% SWITCH m.code %]
>+                    [% CASE 'error_on_saving' %]
>+                        An error occurred when saving this debit type.
>+                    [% CASE 'error_on_delete' %]
>+                        An error occurred when deleting this debit type. Check the logs.
>+                    [% CASE 'success_on_saving' %]
>+                        Debit type saved successfully.
>+                    [% CASE 'success_on_delete' %]
>+                        Debit type deleted successfully.
>+                    [% CASE %]
>+                        [% m.code | html %]
>+                    [% END %]
>+                </div>
>+                [% END %]
>+
>+                [% IF op == 'add_form' %]
>+                    [% IF debit_type %]
>+                        <h3>Modify a debit type</h3>
>+                    [% ELSE %]
>+                        <h3>New debit type</h3>
>+                    [% END %]
>+
>+                    <form action="/cgi-bin/koha/admin/debit_types.pl" name="Aform" method="post" class="validated">
>+                        <input type="hidden" name="op" value="add_validate" />
>+                        <input type="hidden" name="type" value="[% type | html %]" />
>+                        <fieldset class="rows">
>+                            <ol>
>+                                <li>
>+                                    <label for="code" class="required">Debit type code: </label>
>+                                    [% IF debit_type %]
>+                                        <strong>[% debit_type.code | html %]</strong>
>+                                        <input type="hidden" name="code" value="[% code | html %]" />
>+                                    [% ELSE %]
>+                                    <input type="text" name="code" id="code" size="80" maxlength="64" class="required" required="required"><span class="required">Required. Maximum length is 64 letters</span>
>+                                    [% END %]
>+                                </li>
>+                                <li>
>+                                    <label for="default_amount">Default amount: </label>
>+                                    <input type="text" pattern="^\d+(\.\d{2})?$" name="default_amount" id="default_amount" size="80" maxlength="100" value="[% debit_type.default_amount | $Price on_editing => 1 %]" step="any" min="0"/>
>+                                </li>
>+                                <li>
>+                                    <label for="description" class="required">Description: </label>
>+                                    <input type="text" name="description" id="description" required="required" class="required" size="80" maxlength="100" value="[% debit_type.description | html %]" /> <span class="required">Required</span>
>+                                </li>
>+                                <li>
>+                                    <label for="can_be_added_manually">Can be added manually? </label>
>+                                    [% IF debit_type.can_be_added_manually %]
>+                                        <input type="checkbox" name="can_be_added_manually" id="can_be_added_manually" checked="checked" value="1" />
>+                                    [% ELSE %]
>+                                        <input type="checkbox" name="can_be_added_manually" id="can_be_added_manually" value="1" />
>+                                    [% END %]
>+                                </li>
>+                                <li>
>+                                    <label for="branches">Libraries limitation: </label>
>+                                    <select id="branches" name="branches" multiple size="10">
>+                                        <option value="">All libraries</option>
>+                                        [% FOREACH branch IN branches_loop %]
>+                                        [% IF ( branch.selected ) %]
>+                                        <option selected="selected" value="[% branch.branchcode | html %]">[% branch.branchname | html %]</option>
>+                                        [% ELSE %]
>+                                        <option value="[% branch.branchcode | html %]">[% branch.branchname | html %]</option>
>+                                        [% END %]
>+                                        [% END %]
>+                                    </select>
>+                                    <span>Select 'All libraries' if this debit type should be available at all libraries. Otherwise select libraries you want to associate debit type with.</span>
>+                                </li>
>+                            </ol>
>+                        </fieldset>
>+
>+                        <fieldset class="action">
>+                            <button id="save_debit_type" class="btn btn-default"><i class="fa fa-save"></i> Save</button>
>+                            <a class="cancel btn-link" href="/cgi-bin/koha/admin/debit_types.pl"><i class="fa fa-times"></i> Cancel</a>
>+                        </fieldset>
>+                    </form>
>+                [% END %]
>+
>+                [% IF op == 'delete_confirm' %]
>+                    <div class="dialog alert">
>+                        <h3>Delete debit type "[% debit_type.description | html %]?"</h3>
>+                        <table>
>+                            <tr><th>Debit type code</th>
>+                                <td>[% debit_type.code | html %]</td>
>+                            </tr>
>+                            <tr><th>Debit type description</th>
>+                                <td>[% debit_type.description | html %]</td>
>+                            </tr>
>+                        </table>
>+                        <form action="/cgi-bin/koha/admin/debit_types.pl" method="post">
>+                            <input type="hidden" name="op" value="delete_confirmed" />
>+                            <input type="hidden" name="code" value="[% debit_type.code | html %]" />
>+                            <input type="hidden" name="type" value="[% type | html %]" />
>+                            <button type="submit" class="btn btn-default approve"><i class="fa fa-fw fa-check"></i> Yes, delete</button>
>+                        </form>
>+                        <form action="/cgi-bin/koha/admin/debit_types.pl" method="get">
>+                            <button type=submit" class="btn btn-default deny"><i class="fa fa-fw fa-remove"></i> No, do not delete</button>
>+                        </form>
>+                    </div>
>+                [% END %]
>+
>+                [% IF op == 'list' %]
>+                    <div id="toolbar" class="btn-toolbar">
>+                        <a class="btn btn-default" id="newdebittype" href="/cgi-bin/koha/admin/debit_types.pl?op=add_form&type=debit"><i class="fa fa-plus"></i> New debit type</a>
>+                    </div>
>+
>+                    <h3>Account debit types</h3>
>+                    [% IF debit_types.count %]
>+                        <table id="table_debit_types">
>+                            <thead>
>+                                <th>Code</th>
>+                                <th>Description</th>
>+                                <th>Default amount</th>
>+                                <th>Can be added manually</th>
>+                                <th>Library limitations</th>
>+                                <th>Actions</th>
>+                            </thead>
>+                            <tbody>
>+                                [% FOREACH debit_type IN debit_types %]
>+                                <tr>
>+                                    <td>[% debit_type.code | html %]</td>
>+                                    <td>[% debit_type.description | html %]</td>
>+                                    <td>[% debit_type.default_amount | $Price %]</td>
>+                                    <td>[% IF debit_type.can_be_added_manually %]Yes[% ELSE %]No[% END %]</td>
>+                                    <td>
>+                                        [% IF debit_type.library_limits.count > 0 %]
>+                                            [% library_limits_str = "" %]
>+                                            [% FOREACH library IN debit_type.library_limits %]
>+                                                [%- IF loop.first -%]
>+                                                [% library_limits_str = library.branchname _ " (" _ library.branchcode _ ")" %]
>+                                                [% ELSE %]
>+                                                [% library_limits_str = library_limits_str _ "\n" _ library.branchname _ " (" _ library.branchcode _ ")" %]
>+                                                [% END %]
>+                                            [% END %]
>+                                            <span class="library_limitation" title="[% library_limits_str | html %]">
>+                                                [% IF debit_type.library_limits.count > 1 %]
>+                                                    [% debit_type.library_limits.count | html %] library limitations
>+                                                [% ELSE %]
>+                                                    [% debit_type.library_limits.count | html %] library limitation
>+                                                [% END %]
>+                                        [% ELSE %]
>+                                            No limitation
>+                                        [% END %]
>+                                    </td>
>+                                    <td class="actions">
>+                                        [% IF !debit_type.is_system %]
>+                                        <a class="btn btn-default btn-xs" href="/cgi-bin/koha/admin/debit_types.pl?op=add_form&amp;code=[% debit_type.code | uri %]&type=debit"><i class="fa fa-pencil"></i> Edit</a>
>+                                        <a class="btn btn-default btn-xs" href="/cgi-bin/koha/admin/debit_types.pl?op=delete_confirm&amp;code=[% debit_type.code | uri %]&type=debit"><i class="fa fa-trash"></i> Delete</a>
>+                                        [% END %]
>+                                    </td>
>+                                </tr>
>+                                [% END %]
>+                            </tbody>
>+                        </table>
>+                    [% ELSE %]
>+                        <div class="dialog message">
>+                            There are no account debit types defined. <a href="/cgi-bin/koha/admin/debit_types.pl?op=add_form&type=debit">Create new debit type</a>
>+                        </div>
>+                    [% END %]
>+                [% END %]
>+            </main>
>+        </div> 
>+
>+        <div class="col-sm-2 col-sm-pull-10">
>+            <aside>
>+                [% INCLUDE 'admin-menu.inc' %]
>+            </aside>
>+        </div> 
>+    </div> 
>+
>+[% MACRO jsinclude BLOCK %]
>+    [% Asset.js("js/admin-menu.js") | $raw %]
>+    [% INCLUDE 'datatables.inc' %]
>+
>+    <script>
>+        $(document).ready(function() {
>+            $("#table_debit_types").dataTable($.extend(true, {}, dataTablesDefaults, {
>+                "aoColumnDefs": [
>+                    { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false },
>+                ],
>+                "aaSorting": [[ 1, "asc" ]],
>+                "iDisplayLength": 10,
>+                "sPaginationType": "full_numbers"
>+            }));
>+        });
>+    </script>
>+[% END %]
>+
>+[% INCLUDE 'intranet-bottom.inc' %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23049: 93513 | 93514 | 93515 | 93516 | 93518 | 93519 | 93520 | 93521 | 93522 | 93523 | 93529 | 93557 | 93564 | 93565 | 93567 | 93568 | 93569 | 93570 | 93571 | 93572 | 93573 | 93574 | 93575 | 93576 | 93577 | 93578 | 93579 | 93960 | 93961 | 93962 | 93963 | 93964 | 93965 | 93966 | 93967 | 93968 | 93969 | 93970 | 93972 | 93973 | 93974 | 93975 | 93976 | 93977 | 93978 | 93979 | 93989 | 93990 | 93991 | 93992 | 93993 | 93994 | 93995 | 93996 | 93997 | 93998 | 93999 | 94000 | 94001 | 94002 | 94003 | 94004 | 94005 | 94006 | 94007 | 94008 | 94073 | 94074 | 94075 | 94076 | 94077 | 94078 | 94079 | 94080 | 94081 | 94082 | 94083 | 94084 | 94085 | 94086 | 94087 | 94088 | 94089 | 94090 | 94091 | 94092 | 94093 | 94111 | 94112 | 94113 | 94114 | 94115 | 94116 | 94117 | 94118 | 94119 | 94120 | 94121 | 94122 | 94123 | 94124 | 94125 | 94126 | 94127 | 94128 | 94129 | 94130 | 94131 | 94132 | 94133 | 94134 | 94135 | 94136 | 94137 | 94138 | 94139 | 94140 | 94141 | 94142 | 94143 | 94144 | 94145 | 94146 | 94147 | 94148 | 94149 | 94150 | 94151 | 94152 | 94165 | 94307 | 94308 | 94309 | 94310 | 94311 | 94312 | 94313 | 94314 | 94315 | 94316 | 94317 | 94318 | 94319 | 94320 | 94321 | 94323 | 94324 | 94325 | 94326 | 94327 | 94328 | 94329 | 94331 | 94332 | 94333 | 94334 | 94335 | 94336 | 94337 | 94338 | 94339 | 94340 | 94341 | 94342 | 94343 | 94344 | 94345 | 94346 | 94347 | 94348 | 94349 | 94350 | 94351 | 94352 | 94648