Bugzilla – Attachment 94457 Details for
Bug 11879
Add a new field to patron record: main contact method
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11879: (follow-up) Streamline markup and make label corrections
Bug-11879-follow-up-Streamline-markup-and-make-lab.patch (text/plain), 3.72 KB, created by
Bin Wen
on 2019-10-21 15:52:46 UTC
(
hide
)
Description:
Bug 11879: (follow-up) Streamline markup and make label corrections
Filename:
MIME Type:
Creator:
Bin Wen
Created:
2019-10-21 15:52:46 UTC
Size:
3.72 KB
patch
obsolete
>From 83b786d09930f2ca390d03a38b0882406ff1551c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 8 Nov 2017 18:12:51 +0000 >Subject: [PATCH] Bug 11879: (follow-up) Streamline markup and make label > corrections > >This patch makes minor markup corrections to the patron detail page >template: > >- Simplify the SWITCH markup >- Add "primary" to primary phone label >- Correct case on label >- Add IF statement to hide label if there is no primary contact > method > >Signed-off-by: Lucie Gay <lucie.gay@ens-paris-saclay.fr> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> >Signed-off-by: Bin Wen <bin.wen@inlibro.com> >--- > .../prog/en/modules/members/moremember.tt | 31 +++++++++++-------- > 1 file changed, 18 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index eafe8ecff0..2a5135dda1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -280,19 +280,24 @@ > </li> > [% END %] > >- [% SWITCH primary_contact_method %] >- [% CASE 'phone' %] >- <li><span class="label">Main contact method: </span>Phone</li> >- [% CASE 'phonepro' %] >- <li><span class="label">Main contact method: </span>Secondary phone</li> >- [% CASE 'mobile' %] >- <li><span class="label">Main contact method: </span>Other Phone</li> >- [% CASE 'email' %] >- <li><span class="label">Main contact method: </span>Primary email</li> >- [% CASE 'emailpro' %] >- <li><span class="label">Main contact method: </span>Secondary email</li> >- [% CASE 'fax' %] >- <li><span class="label">Main contact method: </span>Fax</li> >+ [% IF ( primary_contact_method ) %] >+ <li> >+ <span class="label">Main contact method: </span> >+ [% SWITCH primary_contact_method %] >+ [% CASE 'phone' %] >+ Primary phone >+ [% CASE 'phonepro' %] >+ Secondary phone >+ [% CASE 'mobile' %] >+ Other phone >+ [% CASE 'email' %] >+ Primary email >+ [% CASE 'emailpro' %] >+ Secondary email >+ [% CASE 'fax' %] >+ Fax >+ [% END %] >+ </li> > [% END %] > </ol> > </div> [% # /div.rows %] >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11879
:
25745
|
25922
|
25941
|
31300
|
31301
|
31320
|
34351
|
34482
|
34502
|
34503
|
34571
|
34572
|
34573
|
41209
|
41220
|
41221
|
41222
|
46101
|
46284
|
46285
|
46286
|
48073
|
48074
|
48075
|
48076
|
48077
|
48078
|
48079
|
48556
|
48557
|
48558
|
48559
|
50433
|
52607
|
52608
|
52614
|
52615
|
52616
|
52617
|
52618
|
52619
|
52620
|
53229
|
53688
|
53695
|
53705
|
53707
|
53708
|
53709
|
53710
|
53711
|
53712
|
53713
|
55946
|
56285
|
56286
|
58580
|
58591
|
58592
|
58593
|
63238
|
63239
|
65811
|
65812
|
69028
|
69029
|
69050
|
71955
|
71956
|
71957
|
71958
|
72632
|
72633
|
72634
|
72635
|
73987
|
73988
|
73989
|
73990
|
74123
|
74124
|
74125
|
74126
|
74818
|
75652
|
83757
|
83758
|
84017
|
84018
|
84019
|
84020
|
84021
|
84022
|
88358
|
88359
|
88360
|
88361
|
88362
|
88363
|
88394
|
88395
|
88396
|
88397
|
88398
|
88399
|
88400
|
93850
|
93851
|
93852
|
93853
|
93854
|
93855
|
93856
|
93900
|
93901
|
94456
|
94457
|
94458
|
94459
|
94460
|
94461
|
94463
|
94464
|
94465
|
94466
|
94467
|
94468
|
96432
|
100817
|
100843
|
112062
|
112063
|
112064
|
112557
|
112559
|
112560
|
118959
|
118960
|
118961
|
118962
|
118985
|
118986
|
118987
|
118988
|
120947
|
120948
|
120949
|
120950
|
122778