Bugzilla – Attachment 94531 Details for
Bug 23233
AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23233: (follow-up) Correct test description
Bug-23233-follow-up-Correct-test-description.patch (text/plain), 1.11 KB, created by
Joonas Kylmälä
on 2019-10-22 11:33:26 UTC
(
hide
)
Description:
Bug 23233: (follow-up) Correct test description
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2019-10-22 11:33:26 UTC
Size:
1.11 KB
patch
obsolete
>From a3f586ea368672675f8abe70b2816f97e77f6be1 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Tue, 22 Oct 2019 11:20:39 +0000 >Subject: [PATCH] Bug 23233: (follow-up) Correct test description > >AllowItemsOnHoldCheckout is not checked anymore but instead only >whether the tmp_holdsqueue is empty or not. >--- > t/db_dependent/Items.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t >index 401c881735..8ac9e7ef22 100755 >--- a/t/db_dependent/Items.t >+++ b/t/db_dependent/Items.t >@@ -322,7 +322,7 @@ subtest 'GetItemsInfo tests' => sub { > $dbh->do(q{INSERT INTO tmp_holdsqueue (biblionumber, itemnumber, surname, borrowernumber ) VALUES (?, ?, "Zorro", 42)}, undef, $item_bibnum, $itemnumber); > @results = GetItemsInfo( $biblio->biblionumber ); > is( $results[0]->{ has_pending_hold }, "1", >- 'Hold marked as pending/unavailable if not AllowItemsOnHoldCheckout' ); >+ 'Hold marked as pending/unavailable if tmp_holdsqueue is not empty for item' ); > > $schema->storage->txn_rollback; > }; >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23233
:
91114
|
91139
|
91143
|
91144
|
94526
|
94527
|
94528
|
94529
|
94530
|
94531
|
94556
|
94557
|
94558
|
96247
|
96248
|
96249
|
96250
|
96251
|
96252
|
96345
|
96358