Attachment 94535 Details for Bug 23858 – Bug 23858: Make POST add the Location header on vendors endpoint

[patch] Bug 23858: Make POST add the Location header on vendors endpoint

Bug-23858-Make-POST-add-the-Location-header-on-ven.patch (text/plain), 1.29 KB, created by Joonas Kylmälä on 2019-10-22 12:02:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2019-10-22 12:02:17 UTC

Size: 1.29 KB

patch

obsolete

>From ed296704cd8c71b16706f187ef736633809ebed1 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 21 Oct 2019 14:23:15 -0300
>Subject: [PATCH] Bug 23858: Make POST add the Location header on vendors
> endpoint
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>According to the coding guidelines, this endpoint should be adding the
>Location header on POST actions.
>
>To test:
>1. Apply the tests patch
>2. Run:
>   $ kshell
>  k$ prove t/db_dependent/api/v1/acquisition_vendors.t
>=> FAIL: Tests fail!
>3. Apply this patch
>4. Repeat (1)
>=> SUCCESS: Tests pass!
>5. Sign off :-D
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@helsinki.fi>
>---
> Koha/REST/V1/Acquisitions/Vendors.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/Koha/REST/V1/Acquisitions/Vendors.pm b/Koha/REST/V1/Acquisitions/Vendors.pm
>index f5686b0ded..a051c2e7ee 100644
>--- a/Koha/REST/V1/Acquisitions/Vendors.pm
>+++ b/Koha/REST/V1/Acquisitions/Vendors.pm
>@@ -101,6 +101,7 @@ sub add_vendor {
> 
>     return try {
>         $vendor->store;
>+        $c->res->headers->location($c->req->url->to_string . '/' . $vendor->id );
>         return $c->render(
>             status  => 200,
>             openapi => $vendor->to_api
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 23858: 94480 | 94481 | 94482 | 94534 | 94535 | 94536 | 94796 | 94797 | 94798