Attachment 94555 Details for Bug 18795 – Bug 18795: (follow-up) Unify error message to be same across codebase

[patch] Bug 18795: (follow-up) Unify error message to be same across codebase

0002-Bug-18795-follow-up-Unify-error-message-to-be-same-a.patch (text/plain), 1.43 KB, created by Johanna Räisä on 2019-10-22 13:15:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Johanna Räisä

Created: 2019-10-22 13:15:59 UTC

Size: 1.43 KB

patch

obsolete

>From 77190144c215c94b2ba7d9a24854dd93ebceebaa Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
>Date: Tue, 22 Oct 2019 12:48:17 +0000
>Subject: [PATCH 2/2] Bug 18795: (follow-up) Unify error message to be same
> across codebase
>
>In Koha/REST/V1/Patrons.pm the error message for not finding patron is
>"Patron not found" so let's use the same here.
>
>Signed-off-by: Johanna Raisa <johanna.raisa@gmail.com>
>---
> Koha/REST/V1/Checkouts.pm         | 2 +-
> t/db_dependent/api/v1/checkouts.t | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/REST/V1/Checkouts.pm b/Koha/REST/V1/Checkouts.pm
>index 887714d22c..0c1afa26e8 100644
>--- a/Koha/REST/V1/Checkouts.pm
>+++ b/Koha/REST/V1/Checkouts.pm
>@@ -199,7 +199,7 @@ sub delete_history {
> 
>     unless ($patrons->count) {
>         return $c->render( status => 404, openapi => {
>-            error => "Patron doesn't exist"
>+            error => "Patron not found"
>         });
>     }
> 
>diff --git a/t/db_dependent/api/v1/checkouts.t b/t/db_dependent/api/v1/checkouts.t
>index a1df3a6254..77cb31372f 100644
>--- a/t/db_dependent/api/v1/checkouts.t
>+++ b/t/db_dependent/api/v1/checkouts.t
>@@ -232,4 +232,4 @@ $patron_to_delete->delete;
> 
> $t->delete_ok( "//$userid:$password@/api/v1/checkouts/history?patron_id=$patron_to_delete_id")
>   ->status_is(404)
>-  ->json_is({error => "Patron doesn't exist"});
>+  ->json_is({error => "Patron not found"});
>-- 
>2.17.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 18795: 64255 | 94533 | 94547 | 94548 | 94549 | 94552 | 94555 | 95246 | 95247 | 95248 | 95265 | 95266 | 95267 | 95463 | 95464 | 95465