Bugzilla – Attachment 94556 Details for
Bug 23233
AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23233: (follow-up) Remove accidentally left comment
Bug-23233-follow-up-Remove-accidentally-left-comme.patch (text/plain), 1.20 KB, created by
Lari Taskula
on 2019-10-22 13:24:40 UTC
(
hide
)
Description:
Bug 23233: (follow-up) Remove accidentally left comment
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2019-10-22 13:24:40 UTC
Size:
1.20 KB
patch
obsolete
>From 7822f26aa05ab3707b2343ee0d9f5b1ed8f2c9de Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Tue, 22 Oct 2019 11:00:51 +0000 >Subject: [PATCH] Bug 23233: (follow-up) Remove accidentally left comment > >The line > >t::lib::Mocks::mock_preference( 'AllowItemsOnHoldCheckout', 0 ); > >was removed from below this comment line but the comment explaining >what it does was forgotten. > >Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> >--- > t/db_dependent/Koha/Item.t | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t >index d647a24e40..58e13e99c2 100644 >--- a/t/db_dependent/Koha/Item.t >+++ b/t/db_dependent/Koha/Item.t >@@ -74,7 +74,6 @@ subtest 'has_pending_hold() tests' => sub { > my $item = $builder->build_sample_item({ itemlost => 0 }); > my $itemnumber = $item->itemnumber; > >- # disable AllowItemsOnHoldCheckout as it ignores pending holds > $dbh->do("INSERT INTO tmp_holdsqueue (surname,borrowernumber,itemnumber) VALUES ('Clamp',42,$itemnumber)"); > ok( $item->has_pending_hold, "Yes, we have a pending hold"); > $dbh->do("DELETE FROM tmp_holdsqueue WHERE itemnumber=$itemnumber"); >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23233
:
91114
|
91139
|
91143
|
91144
|
94526
|
94527
|
94528
|
94529
|
94530
|
94531
|
94556
|
94557
|
94558
|
96247
|
96248
|
96249
|
96250
|
96251
|
96252
|
96345
|
96358