Bugzilla – Attachment 94612 Details for
Bug 23855
Cannot mark the selected suggestion as "pending"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23855: Fix "Mark selected suggestion as" status
Bug-23855-Fix-Mark-selected-suggestion-as-status.patch (text/plain), 1.75 KB, created by
Nick Clemens (kidclamp)
on 2019-10-23 11:33:15 UTC
(
hide
)
Description:
Bug 23855: Fix "Mark selected suggestion as" status
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-10-23 11:33:15 UTC
Size:
1.75 KB
patch
obsolete
>From 2f8af714adbcad06e61084459890a91722f8d597 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 21 Oct 2019 17:55:17 +0200 >Subject: [PATCH] Bug 23855: Fix "Mark selected suggestion as" status > >On the suggestions management page (suggestion/suggestion.pl) you can >select suggestions and change their status. >But it only works for "ACCEPTED" or "REJECTED". > >Maybe caused by bug 22905. > >Test plan: >Select at least one suggestion on the screen and select the "Pending" >status. >=> The status of the selected suggestions must have been updated > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > suggestion/suggestion.pl | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index ed043083bd..e04e2ef629 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -196,15 +196,12 @@ elsif ($op eq "change" ) { > my $accepted_by = $input->param('acceptedby'); > if ( $STATUS eq "ACCEPTED" ) { > $suggestion = { >- STATUS => $STATUS, > accepteddate => dt_from_string, > acceptedby => C4::Context->userenv->{number}, > }; > } > elsif ( $STATUS eq "REJECTED" ) { > $suggestion = { >- >- STATUS => $STATUS, > rejecteddate => dt_from_string, > rejectedby => C4::Context->userenv->{number}, > }; >@@ -212,6 +209,7 @@ elsif ($op eq "change" ) { > if ($STATUS) { > $suggestion->{manageddate} = dt_from_string; > $suggestion->{managedby} = C4::Context->userenv->{number}; >+ $suggestion->{STATUS} = $STATUS; > } > if ( my $reason = $input->param("reason$tabcode") ) { > if ( $reason eq "other" ) { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23855
:
94462
|
94612
|
94643